fix: resolve all CI lint failures

iamjr15 · iamjr15 · commit f742f5276b70 · 2026-03-07T01:50:08.000+05:30
- Frontend: move ref access from render to useEffect in file-tree.tsx
- Frontend: remove unused eslint-disable directive in LayoutContext.tsx
- Backend: add ARG001 to global ruff ignore (slowapi requires request param)
- Backend: remove f-prefix from strings without placeholders in sb_shell_tool
- Backend: fix implicit Optional in billing.py, clean up unused noqa directives
- Backend: add per-file-ignores for test files (print, os.path, etc.)
- CI: fix Clerk publishable key format for frontend build step
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -75,7 +75,7 @@ jobs:
       NEXT_PUBLIC_SUPABASE_URL: "https://placeholder.supabase.co"
       NEXT_PUBLIC_SUPABASE_ANON_KEY: "placeholder-anon-key"
       NEXT_PUBLIC_BACKEND_URL: "https://placeholder.api.com"
-      NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: "pk_test_placeholder"
+      NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: "pk_test_Y2xlcmsuaW52YWxpZC5jb20k"
       NEXT_PUBLIC_APP_URL: "http://localhost:3000"
     steps:
       - uses: actions/checkout@v4
diff --git a/backend/agent/api.py b/backend/agent/api.py
@@ -179,7 +179,7 @@ async def get_agent_run_with_access_check(client, agent_run_id: str, user_id: st
 @router.post("/thread/{thread_id}/agent/start")
 @limiter.limit("10/minute")
 async def start_agent(
-    request: Request,  # noqa: ARG001 — required by slowapi limiter
+    request: Request,
     thread_id: str,
     body: AgentStartRequest = Body(...),
     user_id: str = Depends(get_current_user_id_from_jwt),
@@ -1177,7 +1177,7 @@ async def generate_and_update_project_name(project_id: str, prompt: str):
 @router.post("/agent/initiate", response_model=InitiateAgentResponse)
 @limiter.limit("5/minute")
 async def initiate_agent_with_files(
-    request: Request,  # noqa: ARG001 — required by slowapi limiter
+    request: Request,
     prompt: str = Form(...),
     model_name: str | None = Form(None),  # Default to None to use config.MODEL_TO_USE
     enable_thinking: bool | None = Form(False),
diff --git a/backend/agent/coding_agent_prompt.py b/backend/agent/coding_agent_prompt.py
@@ -1,7 +1,7 @@
 from agent.base_prompt import get_base_prompt_sections
 
 
-def get_coding_agent_prompt(preview_url: str = "https://localhost:3000") -> str:  # noqa: ARG001 — preview_url injected separately via auto-preview context in run.py
+def get_coding_agent_prompt(preview_url: str = "https://localhost:3000") -> str:
     base = get_base_prompt_sections()
     return f"""
 <identity>
diff --git a/backend/agent/mobile_agent_prompt.py b/backend/agent/mobile_agent_prompt.py
@@ -1,7 +1,7 @@
 from agent.base_prompt import get_base_prompt_sections
 
 
-def get_mobile_agent_prompt(preview_url: str = "https://localhost:8081") -> str:  # noqa: ARG001 — preview_url injected separately via auto-preview context in run.py
+def get_mobile_agent_prompt(preview_url: str = "https://localhost:8081") -> str:
     base = get_base_prompt_sections()
     return f"""
 <identity>
diff --git a/backend/agent/tools/sb_shell_tool.py b/backend/agent/tools/sb_shell_tool.py
@@ -142,7 +142,7 @@ def get_tool_schemas(self) -> dict[str, list[ToolSchema]]:
                         XMLNodeMapping(param_name="session_name", node_type="attribute", path=".", required=True),
                         XMLNodeMapping(param_name="kill_session", node_type="attribute", path=".", required=False),
                     ],
-                    example=f"""
+                    example="""
         <function_calls>
         <invoke name="check_command_output">
         <parameter name="session_name">my_session</parameter>
@@ -191,7 +191,7 @@ def get_tool_schemas(self) -> dict[str, list[ToolSchema]]:
                     mappings=[
                         XMLNodeMapping(param_name="session_name", node_type="attribute", path=".", required=True)
                     ],
-                    example=f"""
+                    example="""
         <function_calls>
         <invoke name="terminate_command">
         <parameter name="session_name">my_session</parameter>
diff --git a/backend/deployments/api.py b/backend/deployments/api.py
@@ -247,7 +247,7 @@ async def _execute_vercel_deployment(
 @router.post("/project/{project_id}/deploy/git")
 @limiter.limit("5/minute")
 async def deploy_to_vercel(
-    request: Request,  # noqa: ARG001 — required by slowapi limiter
+    request: Request,
     project_data: tuple[dict[str, Any], str, str] = Depends(get_validated_project_with_quota_check),
 ):
     """Deploy project to Vercel via durable Inngest pipeline.
@@ -258,7 +258,7 @@ async def deploy_to_vercel(
     if not config.VERCEL_BEARER_TOKEN:
         raise HTTPException(status_code=500, detail="Vercel API not configured")
 
-    project, account_id, user_id = project_data  # noqa: F841 — account_id kept for signature compat
+    project, _, user_id = project_data
 
     import inngest as inngest_lib
 
diff --git a/backend/inngest_functions/deployments.py b/backend/inngest_functions/deployments.py
@@ -193,7 +193,7 @@ async def _create_vercel_deployment(project_id: str, project_name: str, files: l
     }
 
 
-async def _save_deployment_record(project_id: str, user_id: str, deployment: dict) -> None:  # noqa: ARG001
+async def _save_deployment_record(project_id: str, user_id: str, deployment: dict) -> None:
     """Save deployment info to Supabase projects table."""
     from services.supabase import DBConnection
 
diff --git a/backend/pyproject.toml b/backend/pyproject.toml
@@ -92,6 +92,7 @@ ignore = [
     "S101",               # assert (per-file-ignores for tests)
     "INP001",             # implicit namespace package
     "TC001", "TC002", "TC003",  # TYPE_CHECKING moves (breaks runtime)
+    "ARG001",             # unused function arg (slowapi @limiter requires `request: Request`)
 
     # FastAPI-specific patterns
     "FAST002",            # non-annotated dependency (FastAPI Depends() pattern)
@@ -149,6 +150,7 @@ ignore = [
 
 [tool.ruff.lint.per-file-ignores]
 "tests/**/*.py" = ["S101", "D", "ANN", "PLR2004", "ARG001", "ARG002"]
+"test_*.py" = ["T201", "F401", "I001", "PTH100", "PTH113", "PTH118", "PTH120", "PTH123", "RUF010", "S101", "D", "ANN"]
 "agent/tools/**/*.py" = ["PLR0913", "ARG002"]
 
 [tool.ruff.lint.isort]
diff --git a/backend/sentry.py b/backend/sentry.py
@@ -6,7 +6,7 @@
 _SENSITIVE_HEADERS = {"authorization", "cookie", "x-api-key", "x-clerk-auth-token"}
 
 
-def _before_send(event, hint):  # noqa: ARG001 — hint required by Sentry callback signature
+def _before_send(event, hint):
     """Scrub sensitive data before sending to Sentry."""
     if "request" in event:
         req = event["request"]
diff --git a/backend/services/billing.py b/backend/services/billing.py
@@ -635,7 +635,7 @@ async def get_payment_methods_for_region(country_code: str, is_subscription: boo
 @router.post("/payment-methods/validate")
 @limiter.limit("10/minute")
 async def validate_payment_methods_endpoint(
-    request: Request, country_code: str = "", payment_methods: list[str] = None, is_subscription: bool = True
+    request: Request, country_code: str = "", payment_methods: list[str] | None = None, is_subscription: bool = True
 ):
     """Validate payment methods for a specific region and transaction type."""
     try:
diff --git a/backend/services/redis.py b/backend/services/redis.py
@@ -507,7 +507,7 @@ async def get_response_list_stats(response_list_key: str) -> dict:
         return {"key": response_list_key, "error": str(e)}
 
 
-async def cleanup_orphaned_agent_keys(max_age_hours: int = 48) -> dict:  # noqa: ARG001
+async def cleanup_orphaned_agent_keys(max_age_hours: int = 48) -> dict:
     """Clean up orphaned agent run keys that may have been left behind.
 
     Scans for agent_run:* keys and removes those that:
diff --git a/backend/test_e2e_sync.py b/backend/test_e2e_sync.py
@@ -710,7 +710,7 @@ def extract_tool_names_from_prompt(prompt_text: str) -> set[str]:
 print("=" * 72)
 
 try:
-    from agent.run import run_agent  # noqa: F811
+    from agent.run import run_agent
     assert_test("Import agent.run.run_agent succeeds", True)
 except ImportError as e:
     error_str = str(e)
diff --git a/frontend/src/app/(home)/projects/[projectId]/thread/_contexts/LayoutContext.tsx b/frontend/src/app/(home)/projects/[projectId]/thread/_contexts/LayoutContext.tsx
@@ -58,7 +58,6 @@ function SearchParamsSync({
 
   useEffect(() => {
     const debugParam = searchParams.get('debug');
-    // eslint-disable-next-line react-hooks/set-state-in-effect
     setDebugMode(debugParam === 'true');
   }, [searchParams, setDebugMode]);
 
diff --git a/frontend/src/components/magicui/file-tree.tsx b/frontend/src/components/magicui/file-tree.tsx
@@ -130,16 +130,16 @@ const Tree = forwardRef<HTMLDivElement, TreeViewProps>(
     );
 
     // Expand ancestors of the selected element whenever initialSelectedId or elements change.
-    // Using a ref to track previous values so we only expand when inputs actually change,
-    // avoiding the need for a useEffect that simulates an event handler.
     const prevInitRef = React.useRef<{ id: string | undefined; elements: TreeViewElement[] | undefined }>({ id: undefined, elements: undefined });
-    if (
-      initialSelectedId &&
-      (prevInitRef.current.id !== initialSelectedId || prevInitRef.current.elements !== elements)
-    ) {
-      prevInitRef.current = { id: initialSelectedId, elements };
-      expandSpecificTargetedElements(elements, initialSelectedId);
-    }
+    React.useEffect(() => {
+      if (
+        initialSelectedId &&
+        (prevInitRef.current.id !== initialSelectedId || prevInitRef.current.elements !== elements)
+      ) {
+        prevInitRef.current = { id: initialSelectedId, elements };
+        expandSpecificTargetedElements(elements, initialSelectedId);
+      }
+    }, [initialSelectedId, elements, expandSpecificTargetedElements]);
 
     const direction = dir === 'rtl' ? 'rtl' : 'ltr';
 
@@ -394,15 +394,16 @@ const CollapseButton = forwardRef<
     }, [setExpandedItems]);
 
     // Expand all tree nodes when expandAll prop becomes true or elements change.
-    // Computed during render with a ref guard instead of useEffect.
     const prevExpandAllRef = React.useRef<{ expandAll: boolean; elements: TreeViewElement[] }>({ expandAll: false, elements: [] });
-    if (
-      expandAll &&
-      (prevExpandAllRef.current.expandAll !== expandAll || prevExpandAllRef.current.elements !== elements)
-    ) {
-      prevExpandAllRef.current = { expandAll, elements };
-      expendAllTree(elements);
-    }
+    React.useEffect(() => {
+      if (
+        expandAll &&
+        (prevExpandAllRef.current.expandAll !== expandAll || prevExpandAllRef.current.elements !== elements)
+      ) {
+        prevExpandAllRef.current = { expandAll, elements };
+        expendAllTree(elements);
+      }
+    }, [expandAll, elements, expendAllTree]);
 
     return (
       <Button

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ async def _create_vercel_deployment(project_id: str, project_name: str, files: l`
`193`	`193`	`}`
`194`	`194`
`195`	`195`
`196`		`-async def _save_deployment_record(project_id: str, user_id: str, deployment: dict) -> None: # noqa: ARG001`
	`196`	`+async def _save_deployment_record(project_id: str, user_id: str, deployment: dict) -> None:`
`197`	`197`	`"""Save deployment info to Supabase projects table."""`
`198`	`198`	`from services.supabase import DBConnection`
`199`	`199`