From 05fa374da180179232fcafef4c64fa84cb1926d0 Mon Sep 17 00:00:00 2001 From: prpr19xx <58330423+prpr19xx@users.noreply.github.com> Date: Sat, 7 Mar 2020 14:01:54 +0000 Subject: [PATCH 1/2] Fix buffer overrun warnings. --- dataxfer.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/dataxfer.c b/dataxfer.c index b99cabf..4484281 100644 --- a/dataxfer.c +++ b/dataxfer.c @@ -1044,7 +1044,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \Y -> year */ case 'Y': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%d", time->tm_year + 1900); for (dp = d; *dp; dp++) op(data, *dp); @@ -1054,7 +1054,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \y -> day of the year (days since Jan 1) */ case 'y': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%d", time->tm_yday); for (dp = d; *dp; dp++) op(data, *dp); @@ -1075,7 +1075,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \m -> month (as a number) */ case 'm': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%d", time->tm_mon); for (dp = d; *dp; dp++) op(data, *dp); @@ -1096,7 +1096,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \D -> day of the month */ case 'D': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%d", time->tm_mday); for (dp = d; *dp; dp++) op(data, *dp); @@ -1106,7 +1106,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \H -> hour (24-hour time) */ case 'H': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%2.2d", time->tm_hour); for (dp = d; *dp; dp++) op(data, *dp); @@ -1116,7 +1116,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \h -> hour (12-hour time) */ case 'h': { - char d[10], *dp; + char d[12], *dp; int v; v = time->tm_hour; @@ -1133,7 +1133,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \i -> minute */ case 'i': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%2.2d", time->tm_min); for (dp = d; *dp; dp++) op(data, *dp); @@ -1144,7 +1144,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, case 'S': seconds: { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%2.2d", time->tm_sec); for (dp = d; *dp; dp++) op(data, *dp); @@ -1174,7 +1174,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \T -> time (HH:MM:SS) */ case 'T': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%2.2d:%2.2d:%2.2d", time->tm_hour, time->tm_min, time->tm_sec); for (dp = d; *dp; dp++) @@ -1195,7 +1195,7 @@ process_str(port_info_t *port, struct tm *time, struct timeval *tv, /* \U -> microseconds in the current second */ case 'U': { - char d[10], *dp; + char d[12], *dp; snprintf(d, sizeof(d), "%6.6ld", tv->tv_usec); for (dp = d; *dp; dp++) op(data, *dp); From eb414b27031acf8386b72f8b38e69b372b11cb94 Mon Sep 17 00:00:00 2001 From: prpr19xx <58330423+prpr19xx@users.noreply.github.com> Date: Sat, 7 Mar 2020 14:13:23 +0000 Subject: [PATCH 2/2] Fix typo. --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index c4e6057..9e2db26 100644 --- a/README +++ b/README @@ -3,7 +3,7 @@ ports. See the man page for information about using the program. Note that ser2net supports RFC 2217 (remote control of serial port parameters), but you must have a compliant client. The only one I -know if is kermit (http://www.columbia.edu/kermit). +know of is kermit (http://www.columbia.edu/kermit). If you want the opposite of ser2net (you want to connect to a "local" serial port device that is really remote) then Cyclades has provided