rethrow with context

Author: shirakaba

packages/host/src/node/cli/apple.ts

@@ -12,24 +12,62 @@ import {
   LinkModuleResult,
 } from "./link-modules.js";
 
+function determineInfoPlistPath(frameworkPath: string) {
+  const checkedPaths = new Array<string>();
+
+  // First, assume it is an "unversioned" framework that keeps its Info.plist in
+  // the root. This is the convention for iOS, tvOS, and friends.
+  let infoPlistPath = path.join(frameworkPath, "Info.plist");
+
+  if (fs.existsSync(infoPlistPath)) {
+    return infoPlistPath;
+  }
+  checkedPaths.push(infoPlistPath);
+
+  // Next, assume it is a "versioned" framework that keeps its Info.plist
+  // under a subdirectory. This is the convention for macOS.
+  infoPlistPath = path.join(
+    frameworkPath,
+    "Versions/Current/Resources/Info.plist",
+  );
+
+  if (fs.existsSync(infoPlistPath)) {
+    return infoPlistPath;
+  }
+  checkedPaths.push(infoPlistPath);
+
+  throw new Error(
+    [
+      `Unable to locate an Info.plist file within framework. Checked the following paths:`,
+      ...checkedPaths.map((checkedPath) => `- ${checkedPath}`),
+    ].join("\n"),
+  );
+}
+
 /**
  * Resolves the Info.plist file within a framework and reads its contents.
  */
 export async function readInfoPlist(frameworkPath: string) {
-  // First, assume it is an "unversioned" framework that keeps its Info.plist in
-  // the root. This is the convention for iOS, tvOS, and friends.
-  let infoPlistPath = path.join(frameworkPath, "Info.plist");
+  let infoPlistPath: string;
+  try {
+    infoPlistPath = determineInfoPlistPath(frameworkPath);
+  } catch (cause) {
+    throw new Error(
+      `Unable to read Info.plist for framework at path "${frameworkPath}", as an Info.plist file couldn't be found.`,
+      { cause },
+    );
+  }
 
-  if (!fs.existsSync(infoPlistPath)) {
-    // Next, assume it is a "versioned" framework that keeps its Info.plist
-    // under a subdirectory. This is the convention for macOS.
-    infoPlistPath = path.join(
-      frameworkPath,
-      "Versions/Current/Resources/Info.plist",
+  let contents: string;
+  try {
+    contents = await fs.promises.readFile(infoPlistPath, "utf-8");
+  } catch (cause) {
+    throw new Error(
+      `Unable to read Info.plist for framework at path "${frameworkPath}", due to a file system error.`,
+      { cause },
     );
   }
 
-  const contents = await fs.promises.readFile(infoPlistPath, "utf-8");
   return { infoPlistPath, contents };
 }