Skip to content

Commit e11fcab

Browse files
authored
Use Node.js LTS Krypton (v24) (#345)
* Upgrade setup-node action and node version on CI * Declare dev-engines in root package.json
1 parent d43350e commit e11fcab

File tree

4 files changed

+62
-49
lines changed

4 files changed

+62
-49
lines changed

.github/workflows/check.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ jobs:
2525
runs-on: ubuntu-latest
2626
steps:
2727
- uses: actions/checkout@v4
28-
- uses: actions/setup-node@v4
28+
- uses: actions/setup-node@v6
2929
with:
30-
node-version: lts/jod
30+
node-version: lts/krypton
3131
# Set up JDK and Android SDK only because we need weak-node-api, to build ferric-example and to run the linting
3232
# TODO: Remove this once we have a way to run linting without building the native code
3333
- name: Set up JDK 17
@@ -64,9 +64,9 @@ jobs:
6464
name: Unit tests (${{ matrix.runner }})
6565
steps:
6666
- uses: actions/checkout@v4
67-
- uses: actions/setup-node@v4
67+
- uses: actions/setup-node@v6
6868
with:
69-
node-version: lts/jod
69+
node-version: lts/krypton
7070
- name: Set up JDK 17
7171
uses: actions/setup-java@v4
7272
with:
@@ -93,9 +93,9 @@ jobs:
9393
name: Weak Node-API tests (${{ matrix.runner }})
9494
steps:
9595
- uses: actions/checkout@v4
96-
- uses: actions/setup-node@v4
96+
- uses: actions/setup-node@v6
9797
with:
98-
node-version: lts/jod
98+
node-version: lts/krypton
9999
- run: npm ci
100100
- run: npm run build
101101
- name: Prepare weak-node-api
@@ -112,9 +112,9 @@ jobs:
112112
runs-on: macos-latest
113113
steps:
114114
- uses: actions/checkout@v4
115-
- uses: actions/setup-node@v4
115+
- uses: actions/setup-node@v6
116116
with:
117-
node-version: lts/jod
117+
node-version: lts/krypton
118118
- name: Set up JDK 17
119119
uses: actions/setup-java@v3
120120
with:
@@ -145,9 +145,9 @@ jobs:
145145
runs-on: macos-latest
146146
steps:
147147
- uses: actions/checkout@v4
148-
- uses: actions/setup-node@v4
148+
- uses: actions/setup-node@v6
149149
with:
150-
node-version: lts/jod
150+
node-version: lts/krypton
151151
- name: Set up JDK 17
152152
uses: actions/setup-java@v3
153153
with:
@@ -176,9 +176,9 @@ jobs:
176176
runs-on: ubuntu-self-hosted
177177
steps:
178178
- uses: actions/checkout@v4
179-
- uses: actions/setup-node@v4
179+
- uses: actions/setup-node@v6
180180
with:
181-
node-version: lts/jod
181+
node-version: lts/krypton
182182
- name: Set up JDK 17
183183
uses: actions/setup-java@v4
184184
with:
@@ -256,9 +256,9 @@ jobs:
256256
runs-on: macos-latest
257257
steps:
258258
- uses: actions/checkout@v4
259-
- uses: actions/setup-node@v4
259+
- uses: actions/setup-node@v6
260260
with:
261-
node-version: lts/jod
261+
node-version: lts/krypton
262262
- name: Set up JDK 17
263263
uses: actions/setup-java@v3
264264
with:

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ jobs:
1818
environment: main
1919
steps:
2020
- uses: actions/checkout@v4
21-
- uses: actions/setup-node@v4
21+
- uses: actions/setup-node@v6
2222
with:
23-
node-version: lts/jod
23+
node-version: lts/krypton
2424
- name: Set up JDK 17
2525
uses: actions/setup-java@v3
2626
with:

package-lock.json

Lines changed: 36 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,5 +75,15 @@
7575
"tsx": "^4.20.6",
7676
"typescript": "^5.8.0",
7777
"typescript-eslint": "^8.38.0"
78+
},
79+
"devEngines": {
80+
"runtime": {
81+
"name": "node",
82+
"version": "^24.0.0"
83+
},
84+
"packageManager": {
85+
"name": "npm",
86+
"version": "^11.0.0"
87+
}
7888
}
7989
}

0 commit comments

Comments
 (0)