Use namespaced targets in node-addon-examples

Author: kraenhansen

packages/node-addon-examples/CMakeLists.txt

@@ -0,0 +1,12 @@
+cmake_minimum_required(VERSION 3.15...3.31)
+project(node-addon-examples)
+
+file(GLOB_RECURSE SUBDIR_CMAKE_LISTS
+  "${CMAKE_CURRENT_SOURCE_DIR}/examples/*/CMakeLists.txt"
+  "${CMAKE_CURRENT_SOURCE_DIR}/tests/*/CMakeLists.txt"
+)
+
+foreach(SUBDIR_CMAKE ${SUBDIR_CMAKE_LISTS})
+  get_filename_component(SUBDIR_PATH ${SUBDIR_CMAKE} DIRECTORY)
+  add_subdirectory(${SUBDIR_PATH} ${SUBDIR_PATH}/build)
+endforeach()

packages/node-addon-examples/package.json

@@ -21,8 +21,8 @@
   },
   "scripts": {
     "copy-examples": "tsx scripts/copy-examples.mts",
-    "gyp-to-cmake": "gyp-to-cmake --weak-node-api .",
-    "build": "tsx scripts/build-examples.mts",
+    "gyp-to-cmake": "gyp-to-cmake --namespaced-targets --weak-node-api .",
+    "build": "cmake-rn --configuration RelWithDebInfo",
     "copy-and-build": "node --run copy-examples && node --run gyp-to-cmake && node --run build",
     "verify": "tsx scripts/verify-prebuilds.mts",
     "test": "node --run copy-and-build && node --run verify",

packages/node-addon-examples/scripts/build-examples.mts

@@ -3,24 +3,25 @@ project(async-test)
 
 find_package(weak-node-api REQUIRED CONFIG)
 
-add_library(addon SHARED addon.c)
+add_library(async-test-addon SHARED addon.c)
 
 option(BUILD_APPLE_FRAMEWORK "Wrap addon in an Apple framework" ON)
 
 if(APPLE AND BUILD_APPLE_FRAMEWORK)
-  set_target_properties(addon PROPERTIES
+  set_target_properties(async-test-addon PROPERTIES
     FRAMEWORK TRUE
     MACOSX_FRAMEWORK_IDENTIFIER async-test.addon
     MACOSX_FRAMEWORK_SHORT_VERSION_STRING 1.0
     MACOSX_FRAMEWORK_BUNDLE_VERSION 1.0
     XCODE_ATTRIBUTE_SKIP_INSTALL NO
    )
 else()
-  set_target_properties(addon PROPERTIES
+  set_target_properties(async-test-addon PROPERTIES
     PREFIX ""
     SUFFIX .node
+    OUTPUT_NAME addon
    )
 endif()
 
-target_link_libraries(addon PRIVATE weak-node-api)
-target_compile_features(addon PRIVATE cxx_std_17)
+target_link_libraries(async-test-addon PRIVATE weak-node-api)
+target_compile_features(async-test-addon PRIVATE cxx_std_17)

packages/node-addon-examples/tests/async/CMakeLists.txt

@@ -3,24 +3,25 @@ project(buffers-test)
 
 find_package(weak-node-api REQUIRED CONFIG)
 
-add_library(addon SHARED addon.c)
+add_library(buffers-test-addon SHARED addon.c)
 
 option(BUILD_APPLE_FRAMEWORK "Wrap addon in an Apple framework" ON)
 
 if(APPLE AND BUILD_APPLE_FRAMEWORK)
-  set_target_properties(addon PROPERTIES
+  set_target_properties(buffers-test-addon PROPERTIES
     FRAMEWORK TRUE
     MACOSX_FRAMEWORK_IDENTIFIER buffers-test.addon
     MACOSX_FRAMEWORK_SHORT_VERSION_STRING 1.0
     MACOSX_FRAMEWORK_BUNDLE_VERSION 1.0
     XCODE_ATTRIBUTE_SKIP_INSTALL NO
    )
 else()
-  set_target_properties(addon PROPERTIES
+  set_target_properties(buffers-test-addon PROPERTIES
     PREFIX ""
     SUFFIX .node
+    OUTPUT_NAME addon
    )
 endif()
 
-target_link_libraries(addon PRIVATE weak-node-api)
-target_compile_features(addon PRIVATE cxx_std_17)
+target_link_libraries(buffers-test-addon PRIVATE weak-node-api)
+target_compile_features(buffers-test-addon PRIVATE cxx_std_17)