Skip to content

Commit 8e85d15

Browse files
committed
Merge branch 'main' of github.com:dougg0k/react-native-node-api into replace-package-manager
2 parents 4656a57 + e613efe commit 8e85d15

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

.changeset/cyan-sloths-move.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"ferric-cli": patch
3+
---
4+
5+
Fixed cargo build release flag

.github/workflows/check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
with:
5353
node-version: lts/jod
5454
- name: Set up JDK 17
55-
uses: actions/setup-java@v3
55+
uses: actions/setup-java@v4
5656
with:
5757
java-version: "17"
5858
distribution: "temurin"
@@ -115,7 +115,7 @@ jobs:
115115
with:
116116
node-version: lts/jod
117117
- name: Set up JDK 17
118-
uses: actions/setup-java@v3
118+
uses: actions/setup-java@v4
119119
with:
120120
java-version: "17"
121121
distribution: "temurin"

packages/ferric/src/cargo.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,11 @@ type BuildOptions = {
7676

7777
export async function build(options: BuildOptions) {
7878
const { target, configuration } = options;
79-
await spawn("cargo", ["build", "--target", target], {
79+
const args = ["build", "--target", target]
80+
if (configuration.toLowerCase() === 'release') {
81+
args.push('--release')
82+
}
83+
await spawn("cargo", args, {
8084
outputMode: "buffered",
8185
env: {
8286
...process.env,

0 commit comments

Comments
 (0)