Skip to content

Commit 39ce0b1

Browse files
Copilotkraenhansen
andcommitted
Document Node.js LTS version and centralize configuration
Add documentation comment explaining that we're using Node.js v22.x "Jod" LTS (became LTS on October 29, 2024). Centralize the version in an environment variable to make future updates easier and more consistent across all jobs. Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com>
1 parent 6a005db commit 39ce0b1

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

.github/workflows/check.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ env:
55
NDK_VERSION: 27.1.12297006
66
# Enabling the Gradle test on CI (disabled by default because it downloads a lot)
77
ENABLE_GRADLE_TESTS: true
8+
# Node.js LTS version: Using v22.x "Jod" (became LTS on October 29, 2024)
9+
# Previous LTS was v20.x "Iron". See: https://nodejs.org/en/about/previous-releases
10+
NODE_VERSION: lts/jod
811

912
on:
1013
push:
@@ -25,7 +28,7 @@ jobs:
2528
- uses: actions/checkout@v4
2629
- uses: actions/setup-node@v4
2730
with:
28-
node-version: lts/jod
31+
node-version: ${{ env.NODE_VERSION }}
2932
# Set up JDK and Android SDK only because we need weak-node-api, to build ferric-example and to run the linting
3033
# TODO: Remove this once we have a way to run linting without building the native code
3134
- name: Set up JDK 17
@@ -62,7 +65,7 @@ jobs:
6265
- uses: actions/checkout@v4
6366
- uses: actions/setup-node@v4
6467
with:
65-
node-version: lts/jod
68+
node-version: ${{ env.NODE_VERSION }}
6669
- name: Set up JDK 17
6770
uses: actions/setup-java@v4
6871
with:
@@ -84,7 +87,7 @@ jobs:
8487
- uses: actions/checkout@v4
8588
- uses: actions/setup-node@v4
8689
with:
87-
node-version: lts/jod
90+
node-version: ${{ env.NODE_VERSION }}
8891
- name: Set up JDK 17
8992
uses: actions/setup-java@v3
9093
with:
@@ -117,7 +120,7 @@ jobs:
117120
- uses: actions/checkout@v4
118121
- uses: actions/setup-node@v4
119122
with:
120-
node-version: lts/jod
123+
node-version: ${{ env.NODE_VERSION }}
121124
- name: Set up JDK 17
122125
uses: actions/setup-java@v3
123126
with:
@@ -148,7 +151,7 @@ jobs:
148151
- uses: actions/checkout@v4
149152
- uses: actions/setup-node@v4
150153
with:
151-
node-version: lts/jod
154+
node-version: ${{ env.NODE_VERSION }}
152155
- name: Set up JDK 17
153156
uses: actions/setup-java@v4
154157
with:
@@ -229,7 +232,7 @@ jobs:
229232
- uses: actions/checkout@v4
230233
- uses: actions/setup-node@v4
231234
with:
232-
node-version: lts/jod
235+
node-version: ${{ env.NODE_VERSION }}
233236
- name: Set up JDK 17
234237
uses: actions/setup-java@v3
235238
with:

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ name: Release
33
env:
44
# Version here should match the one in React Native template and packages/cmake-rn/src/cli.ts
55
NDK_VERSION: 27.1.12297006
6+
# Node.js LTS version: Using v22.x "Jod" (became LTS on October 29, 2024)
7+
# Previous LTS was v20.x "Iron". See: https://nodejs.org/en/about/previous-releases
8+
NODE_VERSION: lts/jod
69

710
on:
811
push:
@@ -19,7 +22,7 @@ jobs:
1922
- uses: actions/checkout@v4
2023
- uses: actions/setup-node@v4
2124
with:
22-
node-version: lts/jod
25+
node-version: ${{ env.NODE_VERSION }}
2326
- name: Set up JDK 17
2427
uses: actions/setup-java@v3
2528
with:

0 commit comments

Comments
 (0)