Skip to content

Commit 06b03e4

Browse files
committed
Cleaning up
1 parent 5df7b49 commit 06b03e4

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

packages/host/src/node/cli/apple.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -501,12 +501,7 @@ export async function linkXcframework({
501501

502502
const info = await readXcframeworkInfo(path.join(modulePath, "Info.plist"));
503503

504-
// TODO: Assert the existence of environment variables injected by Xcodebuild
505-
// TODO: Pick and assert the existence of the right framework slice based on the environment variables
506-
// TODO: Link the framework into the output path
507-
508504
const expectedSlice = determineFrameworkSlice();
509-
510505
const framework = info.AvailableLibraries.find((framework) => {
511506
return (
512507
expectedSlice.platform === framework.SupportedPlatform &&

packages/host/src/node/cli/xcode-helpers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import assert from "node:assert";
22
import path from "node:path";
33
import fs from "node:fs";
4-
import cp from "node:child_process";
54

65
// Using xmldom here because this is what @expo/plist uses internally and we might as well re-use it here.
76
// Types come from packages/host/types/xmldom.d.ts (path mapping in tsconfig.node.json) to avoid pulling in lib "dom".

0 commit comments

Comments
 (0)