Skip to content

Commit 3ea046a

Browse files
ljharbclaude
andcommitted
Fix s390x workflow to use working QEMU approach
Remove alternatives and keep only the docker/setup-qemu-action approach that works correctly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 0f7c814 commit 3ea046a

File tree

1 file changed

+1
-44
lines changed

1 file changed

+1
-44
lines changed

.github/workflows/node-s390.yml

Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ name: 'Tests: node.js on s390x'
33
on: [pull_request, push]
44

55
jobs:
6-
# Alternative 1: Using docker/setup-qemu-action with manual docker run
7-
tests-qemu-manual:
6+
tests:
87
runs-on: ubuntu-latest
98
steps:
109
- uses: actions/checkout@v5
@@ -26,45 +25,3 @@ jobs:
2625
npm install && \
2726
npm run tests-only
2827
"
29-
30-
# Alternative 2: Using uraimo/run-on-arch-action (original approach)
31-
tests-run-on-arch:
32-
runs-on: ubuntu-latest
33-
steps:
34-
- uses: actions/checkout@v5
35-
36-
- uses: uraimo/run-on-arch-action@v2
37-
name: Run tests on s390x
38-
with:
39-
arch: s390x
40-
distro: ubuntu22.04
41-
githubToken: ${{ github.token }}
42-
setup: |
43-
mkdir -p "${PWD}/artifacts"
44-
dockerRunArgs: |
45-
--volume "${PWD}/artifacts:/artifacts"
46-
install: |
47-
apt-get update -q -y
48-
apt-get install -q -y curl git
49-
curl -fsSL https://deb.nodesource.com/setup_18.x | bash -
50-
apt-get install -y nodejs
51-
run: |
52-
node -v
53-
npm -v
54-
npm install
55-
npm run tests-only
56-
57-
# Alternative 3: Using GitHub's buildjet runners (if available)
58-
tests-buildjet:
59-
runs-on: buildjet-2vcpu-ubuntu-2204-arm
60-
continue-on-error: true # This might not be available for all repos
61-
steps:
62-
- uses: actions/checkout@v5
63-
64-
- name: Setup Node.js via Docker on s390x
65-
run: |
66-
docker run --rm --platform linux/s390x \
67-
-v $PWD:/workspace \
68-
-w /workspace \
69-
node:18 \
70-
bash -c "npm install && npm run tests-only"

0 commit comments

Comments
 (0)