Skip to content

Improve static typing of ModCDP config parameter shapes#9

Open
pirate wants to merge 1 commit into
split/mod-topology-routerfrom
schema-type-coverage
Open

Improve static typing of ModCDP config parameter shapes#9
pirate wants to merge 1 commit into
split/mod-topology-routerfrom
schema-type-coverage

Conversation

@pirate
Copy link
Copy Markdown
Member

@pirate pirate commented May 26, 2026

Summary

  • add missing JS config schema fields for launcher and upstream options
  • add flat Python TypedDicts for launcher/upstream/injector/client config shapes
  • type the Python client constructor against those config shapes while preserving generic mapping inputs

Validation

  • pnpm exec tsc -p tsconfig.json --noEmit
  • uv --directory python run pyright
  • uv run python -m py_compile python/modcdp/types/modcdp.py python/modcdp/client/ModCDPClient.py
  • pnpm exec vitest run js/test/test.ModCDPClient.ts -t "normalizes nested config owners|defaults service worker suffix" --fileParallelism=false --maxWorkers=1
  • uv --directory python run python -m unittest tests.test_ModCDPClient.ModCDPClientTests.test_constructor_normalizes_nested_config_owners tests.test_ModCDPClient.ModCDPClientTests.test_preserves_explicit_zero_timeout_config tests.test_ModCDPClient.ModCDPClientTests.test_defaults_service_worker_suffix_config_to_modcdp_worker

@pirate pirate changed the title Fill config schema type coverage Improve static typing of ModCDP config parameter shapes May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant