Fix clang-tidy issues

Author: bpcreech

src/v8_py_frontend/isolate_object_collector.cc

@@ -1,6 +1,7 @@
 #include "isolate_object_collector.h"
 #include <v8-isolate.h>
-#include <functional>
+#include <v8-persistent-handle.h>
+#include <v8-value.h>
 #include <mutex>
 #include <tuple>
 #include <utility>

src/v8_py_frontend/isolate_object_collector.h

@@ -1,11 +1,12 @@
 #ifndef INCLUDE_MINI_RACER_ISOLATE_OBJECT_COLLECTOR_H
 #define INCLUDE_MINI_RACER_ISOLATE_OBJECT_COLLECTOR_H
 
+#include <v8-persistent-handle.h>
+#include <v8-value.h>
 #include <condition_variable>
 #include <functional>
 #include <mutex>
 #include <vector>
-#include "gsl_stub.h"
 #include "isolate_manager.h"
 
 namespace MiniRacer {

src/v8_py_frontend/value.cc

@@ -17,6 +17,8 @@
 #include <string>
 #include <string_view>
 #include <utility>
+#include <variant>
+#include <vector>
 #include "isolate_object_collector.h"
 
 namespace MiniRacer {
@@ -84,7 +86,7 @@ Value::Value(v8::Isolate* isolate,
   }
 }
 
-Value::Value(v8::Isolate* isolate,
+Value::Value(v8::Isolate* /*isolate*/,
              IsolateObjectCollector* isolate_object_collector,
              std::string_view val,
              ValueTypes type)
@@ -98,7 +100,7 @@ Value::Value(v8::Isolate* isolate,
   handle_.bytes = msg.data();
 }
 
-Value::Value(v8::Isolate* isolate,
+Value::Value(v8::Isolate* /*isolate*/,
              IsolateObjectCollector* isolate_object_collector,
              bool val)
     : isolate_object_collector_(isolate_object_collector) {
@@ -107,7 +109,7 @@ Value::Value(v8::Isolate* isolate,
   handle_.int_val = val ? 1 : 0;
 }
 
-Value::Value(v8::Isolate* isolate,
+Value::Value(v8::Isolate* /*isolate*/,
              IsolateObjectCollector* isolate_object_collector,
              int64_t val,
              ValueTypes type)
@@ -117,7 +119,7 @@ Value::Value(v8::Isolate* isolate,
   handle_.int_val = val;
 }
 
-Value::Value(v8::Isolate* isolate,
+Value::Value(v8::Isolate* /*isolate*/,
              IsolateObjectCollector* isolate_object_collector,
              double val,
              ValueTypes type)

src/v8_py_frontend/value.h

@@ -1,7 +1,6 @@
 #ifndef INCLUDE_MINI_RACER_VALUE_H
 #define INCLUDE_MINI_RACER_VALUE_H
 
-#include <v8-array-buffer.h>
 #include <v8-context.h>
 #include <v8-local-handle.h>
 #include <v8-message.h>
@@ -101,8 +100,8 @@ class Value {
 
   Value(const Value& other) = delete;
   Value(Value&& other) noexcept = delete;
-  Value& operator=(const Value& other) = delete;
-  Value& operator=(Value&& other) noexcept = delete;
+  auto operator=(const Value& other) -> Value& = delete;
+  auto operator=(Value&& other) noexcept -> Value& = delete;
 
   using Ptr = std::shared_ptr<Value>;