Skip to content
This repository was archived by the owner on Apr 12, 2018. It is now read-only.

Commit 83b0d09

Browse files
author
Oleiade
committed
Fix default values recommandations
1 parent b7aa3a5 commit 83b0d09

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

swf/querysets/history.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def __init__(self, domain, *args, **kwargs):
88
super(HistoryQuerySet, self).__init__(*args, **kwargs)
99
self.domain = domain
1010

11-
def get(self, run_id, workflow_id, page_size=None, max_results=None, reverse=None):
11+
def get(self, run_id, workflow_id, max_results=None, page_size=100, reverse=False):
1212
"""Retrieves a WorkflowExecution history
1313
1414
:param run_id: unique identifier of the workflow execution
@@ -30,9 +30,8 @@ def get(self, run_id, workflow_id, page_size=None, max_results=None, reverse=Non
3030
:param reverse: Should the history events be retrieved in reverse order.
3131
:type reverse: bool
3232
"""
33-
reverse = reverse or False
34-
page_size = page_size or 100
3533
events = []
34+
max_results = max_results or page_size
3635

3736
if max_results < page_size:
3837
page_size = max_results

0 commit comments

Comments
 (0)