Make RatelimitedException a RuntimeException

Author: Andre601

build.gradle

@@ -7,7 +7,7 @@ plugins{
     id 'com.github.johnrengelman.shadow' version '5.2.0'
 }
 
-def ver = new Version(major: 5, minor: 1, revision: 6)
+def ver = new Version(major: 5, minor: 1, revision: 7)
 
 group = "org.botblock"
 version = "$ver"
@@ -27,7 +27,7 @@ dependencies{
     api group: 'com.squareup.okhttp3', name: 'okhttp', version: '4.3.1'
     api group: 'org.json', name: 'json', version: '20190722'
     api group: 'org.jetbrains', name: 'annotations', version: '18.0.0'
-    api(group: 'net.dv8tion', name: 'JDA', version: '4.1.0_100'){
+    api(group: 'net.dv8tion', name: 'JDA', version: '4.1.1_101'){
         exclude(module: 'opus-java')
     }
     api group: 'com.github.ben-manes.caffeine', name: 'caffeine', version: '2.8.0'

src/main/java/org/botblock/javabotblockapi/exceptions/RatelimitedException.java

@@ -23,7 +23,7 @@
  * Indicates that the Java-Wrapper (Bot) was rate-limited by BotBlock.org (Received error code 429)
  * <br>The returned error message contains the route, Bot ID, IP and delay in seconds for when rate limit is removed.
  */
-public class RatelimitedException extends Throwable{
+public class RatelimitedException extends RuntimeException{
     private int delay;
     private String bot_id;
     private String ip;

src/main/java/org/botblock/javabotblockapi/requests/RequestHandler.java

@@ -61,7 +61,7 @@ JSONObject performGetBot(@NotNull String id, boolean disableCache){
 
         try{
             return performGET(url);
-        }catch(IOException | RatelimitedException ex){
+        }catch(IOException ex){
             ex.printStackTrace();
             return null;
         }
@@ -85,7 +85,7 @@ JSONObject performGetList(@NotNull String id, @Nullable String site, boolean dis
             return listCache.get(id, k -> {
                 try{
                     return performGET(finalUrl);
-                }catch(IOException | RatelimitedException ex){
+                }catch(IOException ex){
                     ex.printStackTrace();
                     return null;
                 }
@@ -94,14 +94,14 @@ JSONObject performGetList(@NotNull String id, @Nullable String site, boolean dis
 
         try{
             return performGET(url);
-        }catch(IOException | RatelimitedException ex){
+        }catch(IOException ex){
             ex.printStackTrace();
             return null;
         }
 
     }
 
-    private JSONObject performGET(@NotNull String url) throws IOException, RatelimitedException{
+    private JSONObject performGET(@NotNull String url) throws IOException{
         Request request = new Request.Builder()
                 .url(url)
                 .build();
@@ -111,12 +111,13 @@ private JSONObject performGET(@NotNull String url) throws IOException, Ratelimit
             if(body == null)
                 throw new NullPointerException("Received empty response body.");
 
-            if(body.string().isEmpty())
+            String bodyString = body.string();
+            if(bodyString.isEmpty())
                 throw new NullPointerException("Received empty response body.");
 
             if(!response.isSuccessful()){
                 if(response.code() == 429)
-                    throw new RatelimitedException(body.string());
+                    throw new RatelimitedException(bodyString);
 
                 throw new IOException(String.format(
                         "Could not retrieve information. The server responded with error code %d (%s).",
@@ -125,11 +126,11 @@ private JSONObject performGET(@NotNull String url) throws IOException, Ratelimit
                 ));
             }
 
-            return new JSONObject(body.string());
+            return new JSONObject(bodyString);
         }
     }
 
-    void performPOST(@NotNull JSONObject json, int sites) throws IOException, RatelimitedException{
+    void performPOST(@NotNull JSONObject json, int sites) throws IOException{
         if(sites < 1)
             throw new IllegalStateException("POST action requires at least one site!");
 
@@ -154,12 +155,13 @@ void performPOST(@NotNull JSONObject json, int sites) throws IOException, Rateli
             if(responseBody == null)
                 throw new NullPointerException("Received empty response body.");
 
-            if(responseBody.string().isEmpty())
+            String bodyString = responseBody.string();
+            if(bodyString.isEmpty())
                 throw new NullPointerException("Received empty response body.");
 
             if(!response.isSuccessful()){
                 if(response.code() == 429)
-                    throw new RatelimitedException(responseBody.string());
+                    throw new RatelimitedException(bodyString);
 
                 throw new IOException(String.format(
                         "Could not post Guild count. The server responded with error code %d (%s)",