fix linter warnings

Author: theodore-s-beers

checks/tmdl.go

@@ -4,9 +4,9 @@ import "strings"
 
 const tabWidth = 4
 
-// Find the first line whose left-trimmed text has prefix `query`, and return the
-// "item block": that line plus following lines until the next non-empty line with
-// indent <= the matched line's indent
+// ExtractTmdlBlock finds the first line whose left-trimmed text has prefix `query` and
+// returns the "item block": that line plus following lines until the next non-empty
+// line with indent <= the matched line's indent.
 func ExtractTmdlBlock(input, query string) string {
 	trimmedQuery := strings.TrimSpace(query)
 	if trimmedQuery == "" {

client/auth.go

@@ -25,9 +25,9 @@ type CurrentUserResponse struct {
 }
 
 func FetchAccessToken() (*LoginResponse, error) {
-	api_url := viper.GetString("api_url")
+	apiURL := viper.GetString("api_url")
 	client := &http.Client{}
-	r, err := http.NewRequest("POST", api_url+"/v1/auth/refresh", bytes.NewBuffer([]byte{}))
+	r, err := http.NewRequest("POST", apiURL+"/v1/auth/refresh", bytes.NewBuffer([]byte{}))
 	r.Header.Add("X-Refresh-Token", viper.GetString("refresh_token"))
 	if err != nil {
 		return nil, err
@@ -53,13 +53,13 @@ func FetchAccessToken() (*LoginResponse, error) {
 }
 
 func LoginWithCode(code string) (*LoginResponse, error) {
-	api_url := viper.GetString("api_url")
+	apiURL := viper.GetString("api_url")
 	req, err := json.Marshal(LoginRequest{Otp: code})
 	if err != nil {
 		return nil, err
 	}
 
-	resp, err := http.Post(api_url+"/v1/auth/otp/login", "application/json", bytes.NewReader(req))
+	resp, err := http.Post(apiURL+"/v1/auth/otp/login", "application/json", bytes.NewReader(req))
 	if err != nil {
 		return nil, err
 	}
@@ -116,9 +116,9 @@ func fetchWithAuth(method string, url string) ([]byte, error) {
 }
 
 func fetchWithAuthAndPayload(method string, url string, payload []byte) ([]byte, int, error) {
-	api_url := viper.GetString("api_url")
+	apiURL := viper.GetString("api_url")
 	client := &http.Client{}
-	r, err := http.NewRequest(method, api_url+url, bytes.NewBuffer(payload))
+	r, err := http.NewRequest(method, apiURL+url, bytes.NewBuffer(payload))
 	if err != nil {
 		return nil, 0, err
 	}

client/lessons.go

@@ -112,7 +112,7 @@ type HTTPRequestResponseVariable struct {
 	Path string
 }
 
-// Only one of these fields should be set
+// HTTPRequestTest should have only one field set
 type HTTPRequestTest struct {
 	StatusCode       *int
 	BodyContains     *string

cmd/login.go

@@ -47,9 +47,9 @@ var loginCmd = &cobra.Command{
 			fmt.Print("Welcome to the Boot.dev CLI!\n\n")
 		}
 
-		loginUrl := viper.GetString("frontend_url") + "/cli/login"
+		loginURL := viper.GetString("frontend_url") + "/cli/login"
 
-		fmt.Println("Please navigate to:\n" + loginUrl)
+		fmt.Println("Please navigate to:\n" + loginURL)
 
 		inputChan := make(chan string)
 
@@ -68,7 +68,7 @@ var loginCmd = &cobra.Command{
 		go func() {
 			browser.Stdout = nil
 			browser.Stderr = nil
-			browser.OpenURL(loginUrl)
+			browser.OpenURL(loginURL)
 		}()
 
 		// race the web server against the user's input
@@ -123,8 +123,8 @@ func startHTTPServer(inputChan chan string) {
 	}
 
 	handleRedirect := func(w http.ResponseWriter, r *http.Request) {
-		loginUrl := viper.GetString("frontend_url") + "/cli/login"
-		http.Redirect(w, r, loginUrl, http.StatusSeeOther)
+		loginURL := viper.GetString("frontend_url") + "/cli/login"
+		http.Redirect(w, r, loginURL, http.StatusSeeOther)
 	}
 
 	http.Handle("POST /submit", cors(http.HandlerFunc(handleSubmit)))

cmd/logout.go

@@ -11,10 +11,10 @@ import (
 )
 
 func logout() {
-	api_url := viper.GetString("api_url")
+	apiURL := viper.GetString("api_url")
 	client := &http.Client{}
 	// Best effort - logout should never fail
-	r, _ := http.NewRequest("POST", api_url+"/v1/auth/logout", bytes.NewBuffer([]byte{}))
+	r, _ := http.NewRequest("POST", apiURL+"/v1/auth/logout", bytes.NewBuffer([]byte{}))
 	r.Header.Add("X-Refresh-Token", viper.GetString("refresh_token"))
 	client.Do(r)
 

cmd/root.go

@@ -172,12 +172,12 @@ func requireAuth(cmd *cobra.Command, args []string) {
 		}
 	}
 
-	access_token := viper.GetString("access_token")
-	promptLoginAndExitIf(access_token == "")
+	accessToken := viper.GetString("access_token")
+	promptLoginAndExitIf(accessToken == "")
 
 	// We only refresh if our token is getting stale.
-	last_refresh := viper.GetInt64("last_refresh")
-	if time.Now().Add(-time.Minute*55).Unix() <= last_refresh {
+	lastRefresh := viper.GetInt64("last_refresh")
+	if time.Now().Add(-time.Minute*55).Unix() <= lastRefresh {
 		return
 	}