-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
We added a line "coverage - ignore file" to generated code in #104
This works fine if widget driver is the only generator that produces code. But for example if I combine widget_driver and json_serializable I run into a problem:
widget_driver writes the ignore coverage comment by default while I need to customize the build_runner from json_serializable with a preamble inside build.yaml see this reference. If I do both, I end up with two "coverage - ignore file" comments in all widget_driver generated files.
To Reproduce
Steps to reproduce the behavior, e.g.:
- have json_serializable and widget_driver_generator in class
- create a driver that triggers the generation of a file
- add this to the build.yaml
targets:
$default:
builders:
source_gen:combining_builder:
options:
preamble: |
// coverage:ignore-file
- run
dart run build_runner build --delete-conflicting-outputs - Observe two "coverage - ignore file" comments in generated driver files
Expected behavior
No "coverage - ignore file" comments in generated driver on default. I want only the option to set it with the pramble
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working