From 012eddea38cfe4ddd7ce622d3f76fdedb5fe5a23 Mon Sep 17 00:00:00 2001 From: Rahul Rampure Date: Thu, 25 Dec 2025 01:30:42 +0530 Subject: [PATCH 1/2] fix --- segment_vector.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/segment_vector.go b/segment_vector.go index 7e50ce4..8ea4ae0 100644 --- a/segment_vector.go +++ b/segment_vector.go @@ -20,8 +20,8 @@ package segment import ( "encoding/json" - index "github.com/blevesearch/bleve_index_api" "github.com/RoaringBitmap/roaring/v2" + index "github.com/blevesearch/bleve_index_api" ) type VecPostingsList interface { @@ -71,8 +71,7 @@ type VectorIndex interface { type VectorSegment interface { Segment - InterpretVectorIndex(field string, requiresFiltering bool, except *roaring.Bitmap) ( - VectorIndex, error) + InterpretVectorIndex(field string, except *roaring.Bitmap) (VectorIndex, error) } type VecPosting interface { From 6ce2ed1463b054276c76721a083e2d65152938dc Mon Sep 17 00:00:00 2001 From: Rahul Rampure Date: Fri, 26 Dec 2025 18:03:46 +0530 Subject: [PATCH 2/2] refactor interface --- segment_vector.go | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/segment_vector.go b/segment_vector.go index 8ea4ae0..6ed4208 100644 --- a/segment_vector.go +++ b/segment_vector.go @@ -58,11 +58,18 @@ type VecPostingsIterator interface { } type VectorIndex interface { - // @params: Search params for backing vector index (like IVF, HNSW, etc.) + // Search performs a kNN search for the given query vector and returns a postings list. + // - qVector: the query vector + // - k: the number of similar vectors to return + // - params: additional search parameters Search(qVector []float32, k int64, params json.RawMessage) (VecPostingsList, error) - // @eligibleDocIDs: DocIDs in the segment eligible for the kNN query. - SearchWithFilter(qVector []float32, k int64, eligibleDocIDs []uint64, - params json.RawMessage) (VecPostingsList, error) + // SearchWithFilter performs a kNN search for the given query vector, filtering results based on eligible document IDs. + // - qVector: the query vector + // - k: the number of similar vectors to return + // - eligibleList: list of eligible document IDs to consider + // - params: additional search parameters + SearchWithFilter(qVector []float32, k int64, eligibleList index.EligibleDocumentList, params json.RawMessage) (VecPostingsList, error) + // Close releases any resources held by the VectorIndex. Close() Size() uint64