From 34fca08f413275961731f7cc78005098010b70ed Mon Sep 17 00:00:00 2001 From: atensoftware Date: Thu, 10 Jan 2019 11:01:05 -0500 Subject: [PATCH 1/2] Fix getHeader to be case-insensitive On certain BigCommerce stores, getHeader fails because the X-BC-ApiLimit-Remaining header is all lower-case in the HTTP response. This causes getRequestsRemaining to always return 0 and puts the code into an infinite wait for more requests. Instead, change getHeader to do a case-insensitive search for the header if the exact case is not found. Please merge this into the trunk. --- src/Bigcommerce/Api/Connection.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Bigcommerce/Api/Connection.php b/src/Bigcommerce/Api/Connection.php index 8885434f..f593cbee 100644 --- a/src/Bigcommerce/Api/Connection.php +++ b/src/Bigcommerce/Api/Connection.php @@ -556,6 +556,12 @@ public function getHeader($header) if (array_key_exists($header, $this->responseHeaders)) { return $this->responseHeaders[$header]; } + // Do case-insensitive search + foreach($this->responseHeaders as $k => $v) { + if(strtolower($k) == strtolower($header)) { + return $v; + } + } } /** From 324f91a653105324821f00cf736f634c8e42f3dd Mon Sep 17 00:00:00 2001 From: atensoftware Date: Thu, 10 Jan 2019 13:29:36 -0500 Subject: [PATCH 2/2] Update Connection.php --- src/Bigcommerce/Api/Connection.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Bigcommerce/Api/Connection.php b/src/Bigcommerce/Api/Connection.php index f593cbee..1e5f7fd1 100644 --- a/src/Bigcommerce/Api/Connection.php +++ b/src/Bigcommerce/Api/Connection.php @@ -557,8 +557,8 @@ public function getHeader($header) return $this->responseHeaders[$header]; } // Do case-insensitive search - foreach($this->responseHeaders as $k => $v) { - if(strtolower($k) == strtolower($header)) { + foreach ($this->responseHeaders as $k => $v) { + if (strtolower($k) == strtolower($header)) { return $v; } }