Skip to content

Two comments are created instead of one #334

@shwarcu

Description

@shwarcu

Problem

Function leaveComment is called with different commentId, causing 2 comments in PR being created and updated.

Currently, I have 2 PR comments - one for passed tests, another for failed tests (alert triggered). I would like to have one PR comment created and updated across all workflow runs within that Pull Request.

Suggestion

One of these solutions

  • allow customising this behaviour with github action option (options like "single_pr_comment" or "custom_comment_id")
  • unify commentId to be just the value of benchName always (when it's alert or not)

If you don't have time to implement this option, are you open to contributions?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions