From 9fb19d9df94721662cd2138b91ab7cf0f0e39352 Mon Sep 17 00:00:00 2001
From: Konradsop <konrad.baran@gmx.net>
Date: Fri, 27 Mar 2026 13:24:06 +0100
Subject: [PATCH] docs: add XML documentation for core parameter classes and
 digests

Added XML documentation for RSA, EC, DH, DSA, and ElGamal parameter classes.
Converted Sha256Digest and Sha512Digest JavaDoc to C# XML tags.
Updated KeyParameter documentation for better IntelliSense.
---
 .gitignore                                    |  3 ++
 crypto/src/crypto/digests/Sha256Digest.cs     | 29 +++++++++----------
 crypto/src/crypto/digests/Sha512Digest.cs     | 29 +++++++++----------
 .../parameters/DHPrivateKeyParameters.cs      |  5 ++++
 .../parameters/DHPublicKeyParameters.cs       |  5 ++++
 .../src/crypto/parameters/DsaKeyParameters.cs | 10 ++++---
 .../parameters/DsaPrivateKeyParameters.cs     | 10 ++++---
 .../parameters/DsaPublicKeyParameters.cs      | 10 ++++---
 .../src/crypto/parameters/ECKeyParameters.cs  |  7 +++++
 .../parameters/ECPrivateKeyParameters.cs      |  9 ++++++
 .../parameters/ECPublicKeyParameters.cs       |  9 ++++++
 .../crypto/parameters/ElGamalKeyParameters.cs | 10 ++++---
 .../parameters/ElGamalPrivateKeyParameters.cs | 10 ++++---
 .../parameters/ElGamalPublicKeyParameters.cs  | 10 ++++---
 crypto/src/crypto/parameters/KeyParameter.cs  | 10 +++++++
 .../src/crypto/parameters/RsaKeyParameters.cs |  7 +++++
 .../parameters/RsaPrivateCrtKeyParameters.cs  | 16 ++++++++++
 17 files changed, 133 insertions(+), 56 deletions(-)

diff --git a/.gitignore b/.gitignore
index 65339dcef1..5bfbe02e13 100644
--- a/.gitignore
+++ b/.gitignore
@@ -27,3 +27,6 @@ BC_password.txt
 *.nuget.targets
 *.project.lock.json
 project.lock.json
+.contributions/
+*.log
+build_*.txt
diff --git a/crypto/src/crypto/digests/Sha256Digest.cs b/crypto/src/crypto/digests/Sha256Digest.cs
index 51859697e5..b1e7dac86b 100644
--- a/crypto/src/crypto/digests/Sha256Digest.cs
+++ b/crypto/src/crypto/digests/Sha256Digest.cs
@@ -5,18 +5,16 @@
 
 namespace Org.BouncyCastle.Crypto.Digests
 {
-    /**
-    * Draft FIPS 180-2 implementation of SHA-256. <b>Note:</b> As this is
-    * based on a draft this implementation is subject to change.
-    *
-    * <pre>
-    *         block  word  digest
-    * SHA-1   512    32    160
-    * SHA-256 512    32    256
-    * SHA-384 1024   64    384
-    * SHA-512 1024   64    512
-    * </pre>
-    */
+    /// <summary>Implementation of SHA-256 as defined in FIPS 180-2.</summary>
+    /// <remarks>
+    /// <pre>
+    ///         block  word  digest
+    /// SHA-1   512    32    160
+    /// SHA-256 512    32    256
+    /// SHA-384 1024   64    384
+    /// SHA-512 1024   64    512
+    /// </pre>
+    /// </remarks>
     public class Sha256Digest
 		: GeneralDigest
     {
@@ -26,15 +24,14 @@ public class Sha256Digest
         private uint[] X = new uint[64];
         private int xOff;
 
+        /// <summary>Initializes a new instance of <see cref="Sha256Digest"/>.</summary>
         public Sha256Digest()
         {
 			initHs();
         }
 
-        /**
-        * Copy constructor.  This will copy the state of the provided
-        * message digest.
-        */
+        /// <summary>Initializes a new instance of <see cref="Sha256Digest"/> from an existing one.</summary>
+        /// <param name="t">The digest to copy from.</param>
         public Sha256Digest(Sha256Digest t) : base(t)
         {
 			CopyIn(t);
diff --git a/crypto/src/crypto/digests/Sha512Digest.cs b/crypto/src/crypto/digests/Sha512Digest.cs
index 9156c24bf9..3b70fdc98e 100644
--- a/crypto/src/crypto/digests/Sha512Digest.cs
+++ b/crypto/src/crypto/digests/Sha512Digest.cs
@@ -5,31 +5,28 @@
 
 namespace Org.BouncyCastle.Crypto.Digests
 {
-    /**
-     * Draft FIPS 180-2 implementation of SHA-512. <b>Note:</b> As this is
-     * based on a draft this implementation is subject to change.
-     *
-     * <pre>
-     *         block  word  digest
-     * SHA-1   512    32    160
-     * SHA-256 512    32    256
-     * SHA-384 1024   64    384
-     * SHA-512 1024   64    512
-     * </pre>
-     */
+    /// <summary>Implementation of SHA-512 as defined in FIPS 180-2.</summary>
+    /// <remarks>
+    /// <pre>
+    ///         block  word  digest
+    /// SHA-1   512    32    160
+    /// SHA-256 512    32    256
+    /// SHA-384 1024   64    384
+    /// SHA-512 1024   64    512
+    /// </pre>
+    /// </remarks>
     public class Sha512Digest
         : LongDigest
     {
         private const int DigestLength = 64;
 
+        /// <summary>Initializes a new instance of <see cref="Sha512Digest"/>.</summary>
         public Sha512Digest()
         {
         }
 
-        /**
-         * Copy constructor.  This will copy the state of the provided
-         * message digest.
-         */
+        /// <summary>Initializes a new instance of <see cref="Sha512Digest"/> from an existing one.</summary>
+        /// <param name="t">The digest to copy from.</param>
         public Sha512Digest(
             Sha512Digest t)
             : base(t)
diff --git a/crypto/src/crypto/parameters/DHPrivateKeyParameters.cs b/crypto/src/crypto/parameters/DHPrivateKeyParameters.cs
index fc724df810..2c99ea1b77 100644
--- a/crypto/src/crypto/parameters/DHPrivateKeyParameters.cs
+++ b/crypto/src/crypto/parameters/DHPrivateKeyParameters.cs
@@ -5,11 +5,15 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Diffie-Hellman private key parameters.</summary>
     public class DHPrivateKeyParameters
 		: DHKeyParameters
     {
         private readonly BigInteger x;
 
+        /// <summary>Initializes a new instance of <see cref="DHPrivateKeyParameters"/>.</summary>
+        /// <param name="x">The private value X.</param>
+        /// <param name="parameters">The DH domain parameters.</param>
 		public DHPrivateKeyParameters(
             BigInteger		x,
             DHParameters	parameters)
@@ -27,6 +31,7 @@ public DHPrivateKeyParameters(
             this.x = x;
         }
 
+        /// <summary>Gets the private value X.</summary>
 		public BigInteger X
         {
             get { return x; }
diff --git a/crypto/src/crypto/parameters/DHPublicKeyParameters.cs b/crypto/src/crypto/parameters/DHPublicKeyParameters.cs
index be4a93eb68..c0833cf0a1 100644
--- a/crypto/src/crypto/parameters/DHPublicKeyParameters.cs
+++ b/crypto/src/crypto/parameters/DHPublicKeyParameters.cs
@@ -7,6 +7,7 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Diffie-Hellman public key parameters.</summary>
     public class DHPublicKeyParameters
 		: DHKeyParameters
     {
@@ -46,6 +47,9 @@ private static BigInteger Validate(BigInteger y, DHParameters dhParams)
 
         private readonly BigInteger m_y;
 
+        /// <summary>Initializes a new instance of <see cref="DHPublicKeyParameters"/>.</summary>
+        /// <param name="y">The public point Y.</param>
+        /// <param name="parameters">The DH domain parameters.</param>
 		public DHPublicKeyParameters(BigInteger y, DHParameters	parameters)
 			: base(false, parameters)
         {
@@ -58,6 +62,7 @@ public DHPublicKeyParameters(BigInteger y, DHParameters parameters, DerObjectIde
             m_y = Validate(y, parameters);
         }
 
+        /// <summary>Gets the public point Y.</summary>
         public virtual BigInteger Y => m_y;
 
 		public override bool Equals(object obj)
diff --git a/crypto/src/crypto/parameters/DsaKeyParameters.cs b/crypto/src/crypto/parameters/DsaKeyParameters.cs
index 4097144a5d..04042f24b7 100644
--- a/crypto/src/crypto/parameters/DsaKeyParameters.cs
+++ b/crypto/src/crypto/parameters/DsaKeyParameters.cs
@@ -4,11 +4,15 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Base class for Digital Signature Algorithm (DSA) key parameters.</summary>
     public abstract class DsaKeyParameters
 		: AsymmetricKeyParameter
     {
 		private readonly DsaParameters parameters;
 
+        /// <summary>Initializes a new instance of <see cref="DsaKeyParameters"/>.</summary>
+        /// <param name="isPrivate">Whether the key is private or not.</param>
+        /// <param name="parameters">The DSA domain parameters.</param>
 		protected DsaKeyParameters(
             bool			isPrivate,
             DsaParameters	parameters)
@@ -18,10 +22,8 @@ protected DsaKeyParameters(
             this.parameters = parameters;
         }
 
-		public DsaParameters Parameters
-        {
-            get { return parameters; }
-        }
+        /// <summary>Gets the DSA domain parameters.</summary>
+		public DsaParameters Parameters => parameters;
 
 		public override bool Equals(
 			object obj)
diff --git a/crypto/src/crypto/parameters/DsaPrivateKeyParameters.cs b/crypto/src/crypto/parameters/DsaPrivateKeyParameters.cs
index 2abdd0e4f5..39e7860ed8 100644
--- a/crypto/src/crypto/parameters/DsaPrivateKeyParameters.cs
+++ b/crypto/src/crypto/parameters/DsaPrivateKeyParameters.cs
@@ -4,11 +4,15 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Digital Signature Algorithm (DSA) private key parameters.</summary>
     public class DsaPrivateKeyParameters
 		: DsaKeyParameters
     {
         private readonly BigInteger x;
 
+        /// <summary>Initializes a new instance of <see cref="DsaPrivateKeyParameters"/>.</summary>
+        /// <param name="x">The private value X.</param>
+        /// <param name="parameters">The DSA domain parameters.</param>
 		public DsaPrivateKeyParameters(
             BigInteger		x,
             DsaParameters	parameters)
@@ -20,10 +24,8 @@ public DsaPrivateKeyParameters(
 			this.x = x;
         }
 
-		public BigInteger X
-        {
-            get { return x; }
-        }
+        /// <summary>Gets the private value X.</summary>
+		public BigInteger X => x;
 
 		public override bool Equals(
 			object obj)
diff --git a/crypto/src/crypto/parameters/DsaPublicKeyParameters.cs b/crypto/src/crypto/parameters/DsaPublicKeyParameters.cs
index 3a81bfdd08..356e92b9c9 100644
--- a/crypto/src/crypto/parameters/DsaPublicKeyParameters.cs
+++ b/crypto/src/crypto/parameters/DsaPublicKeyParameters.cs
@@ -4,6 +4,7 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Digital Signature Algorithm (DSA) public key parameters.</summary>
     public class DsaPublicKeyParameters
 		: DsaKeyParameters
     {
@@ -25,6 +26,9 @@ private static BigInteger Validate(BigInteger y, DsaParameters parameters)
 
         private readonly BigInteger y;
 
+        /// <summary>Initializes a new instance of <see cref="DsaPublicKeyParameters"/>.</summary>
+        /// <param name="y">The public value Y.</param>
+        /// <param name="parameters">The DSA domain parameters.</param>
 		public DsaPublicKeyParameters(
             BigInteger		y,
             DsaParameters	parameters)
@@ -36,10 +40,8 @@ public DsaPublicKeyParameters(
 			this.y = Validate(y, parameters);
         }
 
-		public BigInteger Y
-        {
-            get { return y; }
-        }
+        /// <summary>Gets the public value Y.</summary>
+		public BigInteger Y => y;
 
 		public override bool Equals(object obj)
         {
diff --git a/crypto/src/crypto/parameters/ECKeyParameters.cs b/crypto/src/crypto/parameters/ECKeyParameters.cs
index f18c8fd763..d3bb156d55 100644
--- a/crypto/src/crypto/parameters/ECKeyParameters.cs
+++ b/crypto/src/crypto/parameters/ECKeyParameters.cs
@@ -8,6 +8,7 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Base class for elliptic curve key parameters.</summary>
     public abstract class ECKeyParameters
         : AsymmetricKeyParameter
     {
@@ -26,6 +27,10 @@ public abstract class ECKeyParameters
         private readonly string m_algorithm;
         private readonly ECDomainParameters m_parameters;
 
+        /// <summary>Initializes a new instance of <see cref="ECKeyParameters"/>.</summary>
+        /// <param name="algorithm">The algorithm name.</param>
+        /// <param name="isPrivate">Whether the key is private or not.</param>
+        /// <param name="parameters">The EC domain parameters.</param>
         protected ECKeyParameters(string algorithm, bool isPrivate, ECDomainParameters parameters)
             : base(isPrivate)
         {
@@ -50,8 +55,10 @@ protected ECKeyParameters(string algorithm, bool isPrivate, DerObjectIdentifier
             m_parameters = ECNamedDomainParameters.LookupOid(oid: publicKeyParamSet);
         }
 
+        /// <summary>Gets the algorithm name.</summary>
         public string AlgorithmName => m_algorithm;
 
+        /// <summary>Gets the EC domain parameters.</summary>
         public ECDomainParameters Parameters => m_parameters;
 
         public DerObjectIdentifier PublicKeyParamSet => (m_parameters as ECNamedDomainParameters)?.Name;
diff --git a/crypto/src/crypto/parameters/ECPrivateKeyParameters.cs b/crypto/src/crypto/parameters/ECPrivateKeyParameters.cs
index b14ee27e4e..8b5d21ff09 100644
--- a/crypto/src/crypto/parameters/ECPrivateKeyParameters.cs
+++ b/crypto/src/crypto/parameters/ECPrivateKeyParameters.cs
@@ -3,16 +3,24 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Elliptic curve private key parameters.</summary>
     public class ECPrivateKeyParameters
         : ECKeyParameters
     {
         private readonly BigInteger m_d;
 
+        /// <summary>Initializes a new instance of <see cref="ECPrivateKeyParameters"/>.</summary>
+        /// <param name="d">The private scalar D.</param>
+        /// <param name="parameters">The EC domain parameters.</param>
         public ECPrivateKeyParameters(BigInteger d, ECDomainParameters parameters)
             : this("EC", d, parameters)
         {
         }
 
+        /// <summary>Initializes a new instance of <see cref="ECPrivateKeyParameters"/>.</summary>
+        /// <param name="algorithm">The algorithm name.</param>
+        /// <param name="d">The private scalar D.</param>
+        /// <param name="parameters">The EC domain parameters.</param>
         public ECPrivateKeyParameters(string algorithm, BigInteger d, ECDomainParameters parameters)
             : base(algorithm, true, parameters)
         {
@@ -25,6 +33,7 @@ public ECPrivateKeyParameters(string algorithm, BigInteger d, DerObjectIdentifie
             m_d = Parameters.ValidatePrivateScalar(d);
         }
 
+        /// <summary>Gets the private scalar D.</summary>
         public BigInteger D => m_d;
 
         public override bool Equals(object obj) => obj is ECPrivateKeyParameters other && Equals(other);
diff --git a/crypto/src/crypto/parameters/ECPublicKeyParameters.cs b/crypto/src/crypto/parameters/ECPublicKeyParameters.cs
index f2fe1cc68c..c8b1449643 100644
--- a/crypto/src/crypto/parameters/ECPublicKeyParameters.cs
+++ b/crypto/src/crypto/parameters/ECPublicKeyParameters.cs
@@ -6,16 +6,24 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Elliptic curve public key parameters.</summary>
     public class ECPublicKeyParameters
         : ECKeyParameters
     {
         private readonly ECPoint m_q;
 
+        /// <summary>Initializes a new instance of <see cref="ECPublicKeyParameters"/>.</summary>
+        /// <param name="q">The public point Q.</param>
+        /// <param name="parameters">The EC domain parameters.</param>
         public ECPublicKeyParameters(ECPoint q, ECDomainParameters parameters)
             : this("EC", q, parameters)
         {
         }
 
+        /// <summary>Initializes a new instance of <see cref="ECPublicKeyParameters"/>.</summary>
+        /// <param name="algorithm">The algorithm name.</param>
+        /// <param name="q">The public point Q.</param>
+        /// <param name="parameters">The EC domain parameters.</param>
         public ECPublicKeyParameters(string algorithm, ECPoint q, ECDomainParameters parameters)
             : base(algorithm, false, parameters)
         {
@@ -28,6 +36,7 @@ public ECPublicKeyParameters(string algorithm, ECPoint q, DerObjectIdentifier pu
             m_q = ECDomainParameters.ValidatePublicPoint(Parameters.Curve, q);
         }
 
+        /// <summary>Gets the public point Q.</summary>
         public ECPoint Q => m_q;
 
         public override bool Equals(object obj) => obj is ECPublicKeyParameters other && Equals(other);
diff --git a/crypto/src/crypto/parameters/ElGamalKeyParameters.cs b/crypto/src/crypto/parameters/ElGamalKeyParameters.cs
index 146049acac..83a140cf3a 100644
--- a/crypto/src/crypto/parameters/ElGamalKeyParameters.cs
+++ b/crypto/src/crypto/parameters/ElGamalKeyParameters.cs
@@ -4,11 +4,15 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Base class for ElGamal key parameters.</summary>
     public class ElGamalKeyParameters
 		: AsymmetricKeyParameter
     {
         private readonly ElGamalParameters parameters;
 
+        /// <summary>Initializes a new instance of <see cref="ElGamalKeyParameters"/>.</summary>
+        /// <param name="isPrivate">Whether the key is private or not.</param>
+        /// <param name="parameters">The ElGamal domain parameters.</param>
 		protected ElGamalKeyParameters(
             bool				isPrivate,
             ElGamalParameters	parameters)
@@ -18,10 +22,8 @@ protected ElGamalKeyParameters(
             this.parameters = parameters;
         }
 
-		public ElGamalParameters Parameters
-        {
-            get { return parameters; }
-        }
+        /// <summary>Gets the ElGamal domain parameters.</summary>
+		public ElGamalParameters Parameters => parameters;
 
 		public override bool Equals(
             object obj)
diff --git a/crypto/src/crypto/parameters/ElGamalPrivateKeyParameters.cs b/crypto/src/crypto/parameters/ElGamalPrivateKeyParameters.cs
index 6363f2bbb3..42450aa206 100644
--- a/crypto/src/crypto/parameters/ElGamalPrivateKeyParameters.cs
+++ b/crypto/src/crypto/parameters/ElGamalPrivateKeyParameters.cs
@@ -4,11 +4,15 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>ElGamal private key parameters.</summary>
     public class ElGamalPrivateKeyParameters
 		: ElGamalKeyParameters
     {
         private readonly BigInteger x;
 
+        /// <summary>Initializes a new instance of <see cref="ElGamalPrivateKeyParameters"/>.</summary>
+        /// <param name="x">The private value X.</param>
+        /// <param name="parameters">The ElGamal domain parameters.</param>
 		public ElGamalPrivateKeyParameters(
             BigInteger			x,
             ElGamalParameters	parameters)
@@ -20,10 +24,8 @@ public ElGamalPrivateKeyParameters(
 			this.x = x;
         }
 
-		public BigInteger X
-        {
-            get { return x; }
-        }
+        /// <summary>Gets the private value X.</summary>
+		public BigInteger X => x;
 
 		public override bool Equals(
 			object obj)
diff --git a/crypto/src/crypto/parameters/ElGamalPublicKeyParameters.cs b/crypto/src/crypto/parameters/ElGamalPublicKeyParameters.cs
index 25ac625d5f..d1608aa4fa 100644
--- a/crypto/src/crypto/parameters/ElGamalPublicKeyParameters.cs
+++ b/crypto/src/crypto/parameters/ElGamalPublicKeyParameters.cs
@@ -4,11 +4,15 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>ElGamal public key parameters.</summary>
     public class ElGamalPublicKeyParameters
 		: ElGamalKeyParameters
     {
         private readonly BigInteger y;
 
+        /// <summary>Initializes a new instance of <see cref="ElGamalPublicKeyParameters"/>.</summary>
+        /// <param name="y">The public value Y.</param>
+        /// <param name="parameters">The ElGamal domain parameters.</param>
 		public ElGamalPublicKeyParameters(
             BigInteger			y,
             ElGamalParameters	parameters)
@@ -20,10 +24,8 @@ public ElGamalPublicKeyParameters(
 			this.y = y;
         }
 
-		public BigInteger Y
-        {
-            get { return y; }
-        }
+        /// <summary>Gets the public value Y.</summary>
+		public BigInteger Y => y;
 
 		public override bool Equals(
             object obj)
diff --git a/crypto/src/crypto/parameters/KeyParameter.cs b/crypto/src/crypto/parameters/KeyParameter.cs
index 87612a67ea..0199b3ffd2 100644
--- a/crypto/src/crypto/parameters/KeyParameter.cs
+++ b/crypto/src/crypto/parameters/KeyParameter.cs
@@ -7,6 +7,7 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Base class for symmetric key parameters.</summary>
     public class KeyParameter
         : ICipherParameters
     {
@@ -26,11 +27,17 @@ public static KeyParameter Create<TState>(int length, TState state, SpanAction<b
 
         private readonly byte[] m_key;
 
+        /// <summary>Initializes a new instance of <see cref="KeyParameter"/>.</summary>
+        /// <param name="key">The byte array containing the key material.</param>
         public KeyParameter(byte[] key)
         {
             m_key = Arrays.CopyBuffer(key);
         }
 
+        /// <summary>Initializes a new instance of <see cref="KeyParameter"/>.</summary>
+        /// <param name="key">The byte array containing the key material.</param>
+        /// <param name="keyOff">The offset into the byte array where the key starts.</param>
+        /// <param name="keyLen">The length of the key material.</param>
         public KeyParameter(byte[] key, int keyOff, int keyLen)
         {
             m_key = Arrays.CopySegment(key, keyOff, keyLen);
@@ -62,8 +69,11 @@ public void CopyTo(byte[] buf, int off, int len)
             Array.Copy(m_key, 0, buf, off, len);
         }
 
+        /// <summary>Gets the key material.</summary>
+        /// <returns>A copy of the key material as a byte array.</returns>
         public byte[] GetKey() => Arrays.InternalCopyBuffer(m_key);
 
+        /// <summary>Gets the length of the key material in bytes.</summary>
         public int KeyLength => m_key.Length;
 
         internal bool FixedTimeEquals(byte[] data) => Arrays.FixedTimeEquals(m_key, data);
diff --git a/crypto/src/crypto/parameters/RsaKeyParameters.cs b/crypto/src/crypto/parameters/RsaKeyParameters.cs
index f982a14ac6..85f1651c37 100644
--- a/crypto/src/crypto/parameters/RsaKeyParameters.cs
+++ b/crypto/src/crypto/parameters/RsaKeyParameters.cs
@@ -6,6 +6,7 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>Base class for RSA key parameters.</summary>
 	public class RsaKeyParameters
 		: AsymmetricKeyParameter
     {
@@ -49,6 +50,10 @@ private static BigInteger Validate(BigInteger modulus)
         private readonly BigInteger modulus;
         private readonly BigInteger exponent;
 
+        /// <summary>Initializes a new instance of <see cref="RsaKeyParameters"/>.</summary>
+        /// <param name="isPrivate">Whether the key is private or not.</param>
+        /// <param name="modulus">The RSA modulus.</param>
+        /// <param name="exponent">The RSA exponent (public exponent for public keys, private exponent for private keys).</param>
 		public RsaKeyParameters(
             bool		isPrivate,
             BigInteger	modulus,
@@ -70,11 +75,13 @@ public RsaKeyParameters(
 			this.exponent = exponent;
         }
 
+        /// <summary>Gets the RSA modulus.</summary>
 		public BigInteger Modulus
         {
             get { return modulus; }
         }
 
+        /// <summary>Gets the RSA exponent.</summary>
 		public BigInteger Exponent
         {
             get { return exponent; }
diff --git a/crypto/src/crypto/parameters/RsaPrivateCrtKeyParameters.cs b/crypto/src/crypto/parameters/RsaPrivateCrtKeyParameters.cs
index 557ee94e2f..bbc539f79c 100644
--- a/crypto/src/crypto/parameters/RsaPrivateCrtKeyParameters.cs
+++ b/crypto/src/crypto/parameters/RsaPrivateCrtKeyParameters.cs
@@ -6,11 +6,21 @@
 
 namespace Org.BouncyCastle.Crypto.Parameters
 {
+    /// <summary>RSA key parameters for use with the Chinese Remainder Theorem.</summary>
     public class RsaPrivateCrtKeyParameters
         : RsaKeyParameters
     {
         private readonly BigInteger e, p, q, dP, dQ, qInv;
 
+        /// <summary>Initializes a new instance of <see cref="RsaPrivateCrtKeyParameters"/>.</summary>
+        /// <param name="modulus">The RSA modulus.</param>
+        /// <param name="publicExponent">The public exponent.</param>
+        /// <param name="privateExponent">The private exponent.</param>
+        /// <param name="p">The first prime factor (p) of the modulus.</param>
+        /// <param name="q">The second prime factor (q) of the modulus.</param>
+        /// <param name="dP">The CRT exponent for prime p.</param>
+        /// <param name="dQ">The CRT exponent for prime q.</param>
+        /// <param name="qInv">The CRT coefficient (inverse of q mod p).</param>
         public RsaPrivateCrtKeyParameters(
             BigInteger modulus,
             BigInteger publicExponent,
@@ -50,31 +60,37 @@ public RsaPrivateCrtKeyParameters(RsaPrivateKeyStructure rsaPrivateKey)
         {
         }
 
+        /// <summary>Gets the public exponent.</summary>
         public BigInteger PublicExponent
         {
             get { return e; }
         }
 
+        /// <summary>Gets the first prime factor (p) of the modulus.</summary>
         public BigInteger P
         {
             get { return p; }
         }
 
+        /// <summary>Gets the second prime factor (q) of the modulus.</summary>
         public BigInteger Q
         {
             get { return q; }
         }
 
+        /// <summary>Gets the CRT exponent for prime p.</summary>
         public BigInteger DP
         {
             get { return dP; }
         }
 
+        /// <summary>Gets the CRT exponent for prime q.</summary>
         public BigInteger DQ
         {
             get { return dQ; }
         }
 
+        /// <summary>Gets the CRT coefficient (inverse of q mod p).</summary>
         public BigInteger QInv
         {
             get { return qInv; }