Skip to content

Commit 8b1c3d0

Browse files
committed
chore: remove redundant convertToUIShowStyleBase implementations
1 parent 8de0def commit 8b1c3d0

3 files changed

Lines changed: 4 additions & 33 deletions

File tree

meteor/__mocks__/helpers/database.ts

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ import {
3333
SofieIngestSegment,
3434
SofieIngestRundown,
3535
} from '@sofie-automation/blueprints-integration'
36-
import { DBShowStyleBase, UIShowStyleBase } from '@sofie-automation/corelib/dist/dataModel/ShowStyleBase'
36+
import { DBShowStyleBase } from '@sofie-automation/corelib/dist/dataModel/ShowStyleBase'
3737
import { DBShowStyleVariant } from '@sofie-automation/corelib/dist/dataModel/ShowStyleVariant'
3838
import { Blueprint } from '@sofie-automation/corelib/dist/dataModel/Blueprint'
3939
import { ICoreSystem, SYSTEM_ID } from '@sofie-automation/meteor-lib/dist/collections/CoreSystem'
4040
import { stripVersion } from '../../server/systemStatus/semverUtils'
4141
import { internalUploadBlueprint } from '../../server/api/blueprints/api'
42-
import { literal, getRandomId, getRandomString, Complete, normalizeArray } from '@sofie-automation/corelib/dist/lib'
42+
import { literal, getRandomId, getRandomString, normalizeArray } from '@sofie-automation/corelib/dist/lib'
4343
import { protectString, unprotectString } from '@sofie-automation/corelib/dist/protectedString'
4444
import { DBRundown } from '@sofie-automation/corelib/dist/dataModel/Rundown'
4545
import { DBSegment } from '@sofie-automation/corelib/dist/dataModel/Segment'
@@ -887,18 +887,3 @@ export async function setupMockWorker(doc?: Partial<WorkerStatus>): Promise<{
887887

888888
return { worker, workerThreadStatuses: [workerThreadStatus0, workerThreadStatus1] }
889889
}
890-
891-
// const studioBlueprint
892-
// const showStyleBlueprint
893-
// const showStyleVariant
894-
895-
export function convertToUIShowStyleBase(showStyleBase: DBShowStyleBase): UIShowStyleBase {
896-
return literal<Complete<UIShowStyleBase>>({
897-
_id: showStyleBase._id,
898-
name: showStyleBase.name,
899-
hotkeyLegend: showStyleBase.hotkeyLegend,
900-
sourceLayers: applyAndValidateOverrides(showStyleBase.sourceLayersWithOverrides).obj,
901-
outputLayers: applyAndValidateOverrides(showStyleBase.outputLayersWithOverrides).obj,
902-
abChannelDisplay: showStyleBase.abChannelDisplay,
903-
})
904-
}

packages/webui/src/__mocks__/helpers/database.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
SourceLayerType,
88
IBlueprintPieceType,
99
} from '@sofie-automation/blueprints-integration'
10-
import { DBShowStyleBase, UIShowStyleBase } from '@sofie-automation/corelib/dist/dataModel/ShowStyleBase'
10+
import { DBShowStyleBase } from '@sofie-automation/corelib/dist/dataModel/ShowStyleBase'
1111
import { DBShowStyleVariant } from '@sofie-automation/corelib/dist/dataModel/ShowStyleVariant'
1212
import { ICoreSystem, SYSTEM_ID } from '@sofie-automation/meteor-lib/dist/collections/CoreSystem'
1313
import { literal, getRandomId, Complete, normalizeArray } from '@sofie-automation/corelib/dist/lib'
@@ -542,20 +542,6 @@ export async function setupDefaultRundown(
542542
return rundownId
543543
}
544544

545-
// // const studioBlueprint
546-
// // const showStyleBlueprint
547-
// // const showStyleVariant
548-
549-
export function convertToUIShowStyleBase(showStyleBase: DBShowStyleBase): UIShowStyleBase {
550-
return literal<Complete<UIShowStyleBase>>({
551-
_id: showStyleBase._id,
552-
name: showStyleBase.name,
553-
hotkeyLegend: showStyleBase.hotkeyLegend,
554-
sourceLayers: applyAndValidateOverrides(showStyleBase.sourceLayersWithOverrides).obj,
555-
outputLayers: applyAndValidateOverrides(showStyleBase.outputLayersWithOverrides).obj,
556-
abChannelDisplay: showStyleBase.abChannelDisplay,
557-
})
558-
}
559545
export function convertToUIStudio(studio: DBStudio): UIStudio {
560546
return literal<Complete<UIStudio>>({
561547
_id: studio._id,

packages/webui/src/client/lib/__tests__/rundown.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {
22
setupDefaultStudioEnvironment,
33
DefaultEnvironment,
44
setupDefaultRundownPlaylist,
5-
convertToUIShowStyleBase,
65
convertToUIStudio,
76
} from '../../../__mocks__/helpers/database.js'
87
import { RundownUtils } from '../rundown.js'
@@ -18,6 +17,7 @@ import { RundownPlaylistCollectionUtil } from '../../collections/rundownPlaylist
1817
import { RundownPlaylistClientUtil } from '../rundownPlaylistUtil.js'
1918
import { UIStudio } from '@sofie-automation/corelib/src/dataModel/Studio.js'
2019
import { PartInstance } from '@sofie-automation/corelib/src/dataModel/PartInstance.js'
20+
import { convertToUIShowStyleBase } from '@sofie-automation/corelib/src/playout/stateCacheResolver.js'
2121

2222
const mockRundownPlaylistsCollection = MongoMock.getInnerMockCollection(RundownPlaylists)
2323
const mockPartInstancesCollection = MongoMock.getInnerMockCollection(PartInstances)

0 commit comments

Comments
 (0)