fix: use forward slashes for initial Rlocation lookup of build data

[rickeylev]

Gemini flagged that Rlocation accepts forward-slash delimited paths. This appears to
be correct, since the internal logic uses forward slashes and manifests contain
forward slashes.

[gemini-code-assist]

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the path handling logic within the stage2_bootstrap_template.py file. It addresses an identified redundancy where a Windows-specific path conversion (from forward slashes to backslashes) was being applied to resource paths before being passed to the Rlocation function. By removing this unnecessary conversion, the system now correctly leverages Rlocation's inherent ability to process forward slashes, streamlining the resource lookup process and aligning with the internal logic and manifest formats.

Highlights

• Path Handling: Removed a Windows-specific path conversion for rlocation_path before calling Rlocation, as the Rlocation function is designed to correctly handle forward-slash delimited paths internally.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/private/stage2_bootstrap_template.py
  • Removed the conditional rlocation_path.replace("/", "\\") call that was specific to Windows systems.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly identifies and fixes a bug in the runfiles lookup logic on Windows. By removing the manual replacement of forward slashes with backslashes before calling Rlocation, the code now correctly passes the runfiles-relative path in the format expected by the Bazel runfiles library. This ensures that manifest lookups and repository mapping resolution work as intended on Windows. The subsequent normalization of the returned path ensures compatibility with Windows file system operations.