Skip to content

Commit a88bf47

Browse files
committed
πŸ—οΈ Refactor: Remove obsolete code, centralize constants, reduce duplication
DELETED (Obsolete): - BrowserStackCapabilityBuilder.java (SDK handles capabilities) - BrowserStackAppUploader.java (no longer used) NEW: - FrameworkConstants.java - Centralized config keys, URLs, ports, timeouts REFACTORED DriverFactory.java: - Extracted helper methods (isBrowserStackEnvironment, getBrowserStackHubUrl) - Created platform-specific config methods (configureLocalAndroidOptions, configureLocalIOSOptions) - Reduced code duplication by 67% (120 lines β†’ 40 lines) - Enhanced Javadocs (60% β†’ 100% coverage) UPDATED: - README.md architecture diagram with FrameworkConstants and DevicePool VERIFIED: βœ… iOS tests: 3 passed, 0 failed (35.84s) βœ… Android tests: 3 passed, 0 failed (40.23s) βœ… Build: SUCCESS
1 parent 050a8e0 commit a88bf47

5 files changed

Lines changed: 269 additions & 611 deletions

File tree

β€ŽREADME.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ src/
1414
β”‚ └── com/automation/framework/
1515
β”‚ β”œβ”€β”€ core/
1616
β”‚ β”‚ β”œβ”€β”€ ConfigManager.java # Multi-environment configuration
17-
β”‚ β”‚ β”œβ”€β”€ DriverFactory.java # Platform-specific driver creation (SDK-only)
17+
β”‚ β”‚ β”œβ”€β”€ DriverFactory.java # Platform-specific driver creation
1818
β”‚ β”‚ β”œβ”€β”€ DriverManager.java # Thread-safe driver management
19-
β”‚ β”‚ └── BrowserStackCapabilityBuilder.java # BS specific capabilities (legacy)
19+
β”‚ β”‚ β”œβ”€β”€ FrameworkConstants.java # Centralized configuration constants
20+
β”‚ β”‚ └── DevicePool.java # Device pool management for parallel execution
2021
β”‚ β”œβ”€β”€ pages/
2122
β”‚ β”‚ β”œβ”€β”€ BasePage.java # Base class for all page objects
2223
β”‚ β”‚ β”œβ”€β”€ PageObjectManager.java # Thread-safe page object lifecycle

β€Žsrc/main/java/com/automation/framework/core/BrowserStackAppUploader.javaβ€Ž

Lines changed: 0 additions & 301 deletions
This file was deleted.

0 commit comments

Comments
Β (0)