Add flake8 config + modify install processus

Author: Bastien Gautier

.devcontainer/check-post-install.sh

@@ -2,10 +2,25 @@
 
 RED="\e[31m"
 GREEN="\e[32m"
+BLUE="\e[34m"
 ENDCOLOR="\e[0m"
 
-echo -e "\n${GREEN}> Display pip info/version.${ENDCOLOR}\n"
-pip --version
+echo -e "\n${BLUE}#####################################"
+echo -e "${BLUE}####    CHECK-POST-INSTALL.SH    ####${ENDCOLOR}"
+echo -e "${BLUE}#####################################"
+
+source /workspaces/app/.venv/bin/activate
+
+if which pip >/dev/null; then
+    echo -e "\n${GREEN}> Display PIP info/version.${ENDCOLOR}\n"
+    pip --version
+fi
+
+if which poetry >/dev/null; then
+    echo -e "\n${GREEN}> Display POETRY info/version.${ENDCOLOR}\n"
+    poetry --version
+fi
 
 # ADD [here] your other verification todo.
 
+echo -e ""

.devcontainer/install.sh

@@ -2,35 +2,118 @@
 
 RED="\e[31m"
 GREEN="\e[32m"
+BLUE="\e[34m"
+YELLOW="\e[33m"
 ENDCOLOR="\e[0m"
 
-echo -e "\n${GREEN}> Configure environment.${ENDCOLOR}\n"
+echo -e "\n${BLUE}################################"
+echo -e "${BLUE}####       INSTALL.SH       ####${ENDCOLOR}"
+echo -e "${BLUE}################################"
+
+echo -e "\n${GREEN}> Configure virtual environment.${ENDCOLOR}\n"
 
 sudo chgrp vscode /workspaces/app/.venv
 sudo chown vscode /workspaces/app/.venv
 
 git config --global --add safe.directory /workspaces/app
-git config core.eol lf
-git config core.autocrlf false
+git config --global core.eol lf
+git config --global core.autocrlf false
 
 python3 -m venv /workspaces/app/.venv
 PATH="/workspaces/app/.venv/bin:$PATH"
 
 echo -e "Done.\n"
 
-echo -e "${GREEN}> Update pip tool and install dependencies.${ENDCOLOR}\n"
+echo -e "${GREEN}> Identify the packaging and dependency manager to install.${ENDCOLOR}\n"
+
+PIP_MANAGER=false
+POETRY_MANAGER=false
+
+NEW_POETRY_INSTALL=false
+
+FILE=/workspaces/app/requirements.txt
+
+if [ -f "$FILE" ];
+then
+    echo -e "PIP configuration file was found (requirements.txt).\n"
+    PIP_MANAGER=true
+fi
+
+FILE=/workspaces/app/pyproject.toml
+
+if [ -f "$FILE" ];
+then
+    echo -e "POETRY configuration file was found (pyproject.toml).${ENDCOLOR}"
+    POETRY_MANAGER=true
+fi
+
+if [ "$POETRY_MANAGER" = true ] && [ "$PIP_MANAGER" = true ];
+then
+    echo -e "${RED}> ERROR: You cannot define two packaging and dependency manager in the same time.${ENDCOLOR}\n"
+    exit 1
+fi
+
+if [ "$POETRY_MANAGER" = false ] && [ "$PIP_MANAGER" = false ];
+then
+
+    echo -e "${YELLOW}No packaging and dependency manager was found.${ENDCOLOR}"
+    echo -e "${YELLOW}Type 'PIP' or 'POETRY' if you want to install a packaging and dependency manager !${ENDCOLOR}"
+    echo -e "${YELLOW}Another option will install no packaging and dependency manager.${ENDCOLOR}"
+    echo -e "${YELLOW}Your selection :${ENDCOLOR}"
+
+    read MANAGER
+    echo -e "The following packaging and dependency manager will be installed : $MANAGER\n"
+
+    if [ "${MANAGER^^}" = "POETRY" ]
+    then
+        POETRY_MANAGER=true
+        NEW_POETRY_INSTALL=true
+    fi
+
+    if [ "${MANAGER^^}" = "PIP" ]
+    then
+        PIP_MANAGER=true
+        touch /workspaces/app/requirements.txt
+        touch /workspaces/app/requirements-dev.txt
+    fi
+
+fi
 
 source /workspaces/app/.venv/bin/activate
-pip install --upgrade pip
 
-# pip install keyring artifacts-keyring
+if [ "$PIP_MANAGER" = true ];
+then
+
+    echo -e "${GREEN}> Update PIP tool and install dependencies.${ENDCOLOR}\n"
+
+    pip install --upgrade pip
+
+    # pip install keyring artifacts-keyring
+
+    # cat <<EOF >> /workspaces/app/.venv/pip.conf
+    # [global]
+    # extra-index-url=https://pkgs.dev.azure.com/...
+    # EOF
+
+    pip install -r /workspaces/app/requirements-dev.txt
+    pip install -r /workspaces/app/requirements.txt
+
+fi
+
+if [ "$POETRY_MANAGER" = true ];
+then
+
+    echo -e "${GREEN}> Install POETRY tool and install dependencies.${ENDCOLOR}\n"
+    curl -sSL https://install.python-poetry.org | python3 -
+    poetry completions bash >> ~/.bash_completion
+
+    if [ "$POETRY_MANAGER" = true ];
+    then
+        poetry init
+    fi
 
-# cat <<EOF >> /workspaces/app/.venv/pip.conf
-# [global]
-# extra-index-url=https://pkgs.dev.azure.com/...
-# EOF
+    poetry install
 
-pip install -r /workspaces/app/requirements-dev.txt
-pip install -r /workspaces/app/requirements.txt
+fi
 
 /workspaces/app/.devcontainer/check-post-install.sh

.vscode/settings.json

@@ -9,6 +9,8 @@
     "python.linting.mypyArgs": [],
     "python.linting.pylintEnabled": true,
     "python.linting.pylintPath": "/workspaces/app/.venv/bin/pylint",
+    "python.linting.flake8Enabled": true,
+    "python.linting.flake8Path": "/workspaces/app/.venv/bin/flake8",
     "python.linting.enabled": true,
     "python.formatting.provider": "yapf",
     "python.formatting.yapfPath": "/workspaces/app/.venv/bin/yapf",
@@ -19,7 +21,8 @@
     "files.eol": "\n",
     "files.exclude": {
         "**/__pycache__": true,
-        "**/.mypy_cache": true
+        "**/.mypy_cache": true,
+        "**/.venv": true
     },
     "python.analysis.typeCheckingMode": "strict",
     "python.analysis.importFormat": "absolute",

myproject/main.py

@@ -12,6 +12,7 @@
 
 # Pylint: Line too long (110/100)
 # Pylama: Line too long (110 > 100 characters) [pycodestyle]
+# Flake8: Line too long (110 > 100 characters) [pycodestyle]
 # > Change the configuration or the code to resolve the issue.
 
 import pandas as pd

requirements-dev.txt

@@ -2,3 +2,4 @@ pylama
 pylint
 mypy
 yapf
+flake8

setup.cfg

@@ -165,3 +165,10 @@ allow-global-unused-variables=no
 # Only show warnings with the listed confidence levels. Leave empty to show
 # all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED.
 confidence=
+
+[flake8]
+
+# extend-ignore = E203
+max-line-length = 100
+exclude = .git,__pycache__,docs/source/conf.py,old,build,dist
+max-complexity = 10