From 46d069deee652d52c97cb516e34145880622ca3d Mon Sep 17 00:00:00 2001 From: Erick Benitez-Ramos Date: Tue, 28 Jan 2025 20:11:31 +0000 Subject: [PATCH 1/2] fix: skip TF tests for unsupported versions --- .../sagemaker/workflow/test_model_create_and_registration.py | 2 +- tests/integ/sagemaker/workflow/test_model_steps.py | 2 +- tests/integ/sagemaker/workflow/test_training_steps.py | 2 +- tests/integ/test_transformer.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/integ/sagemaker/workflow/test_model_create_and_registration.py b/tests/integ/sagemaker/workflow/test_model_create_and_registration.py index 7f85c0066c..e29e5d1aca 100644 --- a/tests/integ/sagemaker/workflow/test_model_create_and_registration.py +++ b/tests/integ/sagemaker/workflow/test_model_create_and_registration.py @@ -1422,7 +1422,7 @@ def test_model_registration_with_tensorflow_model_with_pipeline_model( pipeline_name, region_name, ): - if Version(tf_full_version) in SpecifierSet("==2.16.*"): + if Version(tf_full_version) >= Version("2.16"): pytest.skip( "This test is failing in TensorFlow 2.16 beacuse of an upstream bug: " "https://github.com/tensorflow/io/issues/2039" diff --git a/tests/integ/sagemaker/workflow/test_model_steps.py b/tests/integ/sagemaker/workflow/test_model_steps.py index 089cdaf08f..f1dd9a9fe0 100644 --- a/tests/integ/sagemaker/workflow/test_model_steps.py +++ b/tests/integ/sagemaker/workflow/test_model_steps.py @@ -592,7 +592,7 @@ def test_model_registration_with_drift_check_baselines_and_model_metrics( def test_model_registration_with_tensorflow_model_with_pipeline_model( pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name ): - if Version(tf_full_version) in SpecifierSet("==2.16.*"): + if Version(tf_full_version) >= Version("2.16"): pytest.skip( "This test is failing in TensorFlow 2.16 beacuse of an upstream bug: " "https://github.com/tensorflow/io/issues/2039" diff --git a/tests/integ/sagemaker/workflow/test_training_steps.py b/tests/integ/sagemaker/workflow/test_training_steps.py index bcff221afe..28efc9743a 100644 --- a/tests/integ/sagemaker/workflow/test_training_steps.py +++ b/tests/integ/sagemaker/workflow/test_training_steps.py @@ -238,7 +238,7 @@ def test_training_step_with_output_path_as_join( def test_tensorflow_training_step_with_parameterized_code_input( pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name ): - if Version(tf_full_version) in SpecifierSet("==2.16.*"): + if Version(tf_full_version) >= Version("2.16"): pytest.skip( "This test is failing in TensorFlow 2.16 beacuse of an upstream bug: " "https://github.com/tensorflow/io/issues/2039" diff --git a/tests/integ/test_transformer.py b/tests/integ/test_transformer.py index 8c99854d14..676eeb6f5e 100644 --- a/tests/integ/test_transformer.py +++ b/tests/integ/test_transformer.py @@ -556,7 +556,7 @@ def test_transform_mxnet_logs( def test_transform_tf_kms_network_isolation( sagemaker_session, cpu_instance_type, tmpdir, tf_full_version, tf_full_py_version ): - if Version(tf_full_version) in SpecifierSet("==2.16.*"): + if Version(tf_full_version) >= Version("2.16"): pytest.skip( "This test is failing in TensorFlow 2.16 beacuse of an upstream bug: " "https://github.com/tensorflow/io/issues/2039" From 262415689942c7e96e867e5437309b4b6f3e944b Mon Sep 17 00:00:00 2001 From: Erick Benitez-Ramos Date: Tue, 28 Jan 2025 20:22:25 +0000 Subject: [PATCH 2/2] flake8 --- .../sagemaker/workflow/test_model_create_and_registration.py | 1 - tests/integ/sagemaker/workflow/test_model_steps.py | 1 - tests/integ/sagemaker/workflow/test_training_steps.py | 1 - tests/integ/test_transformer.py | 1 - 4 files changed, 4 deletions(-) diff --git a/tests/integ/sagemaker/workflow/test_model_create_and_registration.py b/tests/integ/sagemaker/workflow/test_model_create_and_registration.py index e29e5d1aca..8f98cd076d 100644 --- a/tests/integ/sagemaker/workflow/test_model_create_and_registration.py +++ b/tests/integ/sagemaker/workflow/test_model_create_and_registration.py @@ -26,7 +26,6 @@ import pytest from packaging.version import Version -from packaging.specifiers import SpecifierSet from sagemaker.model_card.model_card import ModelCard, ModelOverview, ModelPackageModelCard from sagemaker.model_card.schema_constraints import ModelCardStatusEnum diff --git a/tests/integ/sagemaker/workflow/test_model_steps.py b/tests/integ/sagemaker/workflow/test_model_steps.py index f1dd9a9fe0..02f7613f85 100644 --- a/tests/integ/sagemaker/workflow/test_model_steps.py +++ b/tests/integ/sagemaker/workflow/test_model_steps.py @@ -18,7 +18,6 @@ import pytest from packaging.version import Version -from packaging.specifiers import SpecifierSet from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution from sagemaker.workflow.fail_step import FailStep diff --git a/tests/integ/sagemaker/workflow/test_training_steps.py b/tests/integ/sagemaker/workflow/test_training_steps.py index 28efc9743a..4b442c6d93 100644 --- a/tests/integ/sagemaker/workflow/test_training_steps.py +++ b/tests/integ/sagemaker/workflow/test_training_steps.py @@ -19,7 +19,6 @@ import pytest from packaging.version import Version -from packaging.specifiers import SpecifierSet from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution from sagemaker import TrainingInput, get_execution_role, utils, image_uris diff --git a/tests/integ/test_transformer.py b/tests/integ/test_transformer.py index 676eeb6f5e..0d03aee8ea 100644 --- a/tests/integ/test_transformer.py +++ b/tests/integ/test_transformer.py @@ -19,7 +19,6 @@ import pytest from packaging.version import Version -from packaging.specifiers import SpecifierSet from sagemaker import KMeans, s3, get_execution_role from sagemaker.mxnet import MXNet