[UserError] Regression on `dotnet package` in v6 release - CreateApplicationBundle

[carter-broom]

Describe the bug

When building a package on Github Actions using dotnet publish using the new amazon.lambda.tools we get error:

Run dotnet tool install -g Amazon.Lambda.Tools
Tool 'amazon.lambda.tools' (version '6.0.0') was successfully installed.

Found /etc/os-release
Executing publish command
... invoking 'dotnet publish', working folder '/home/runner/work/app/bin/Release/net9.0/publish'
... dotnet publish "/home/runner/work/app" --output "/home/runner/work/app/bin/Release/net9.0/publish" --configuration "Release" --framework "net9.0" --self-contained true /p:GenerateRuntimeConfigurationFiles=true --runtime linux-x64
... publish:   Determining projects to restore...
....... >>>
Changed permissions on published file (chmod +rx System.Runtime.Serialization.Xml.dll).
Changed permissions on published file (chmod +rx System.ComponentModel.TypeConverter.dll).
Changed permissions on published file (chmod +rx System.Reflection.Primitives.dll).
Unknown error executing command: The value cannot be an empty string. (Parameter 'path')
   at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
   at System.IO.Path.GetFullPath(String path)
   at Amazon.Lambda.Tools.LambdaPackager.CreateApplicationBundle(LambdaToolsDefaults defaults, IToolLogger logger, String workingDirectory, String projectLocation, String configuration, String targetFramework, String msbuildParameters, String architecture, Boolean disableVersionCheck, LayerPackageInfo layerPackageInfo, Boolean isNativeAot, Nullable`1 useContainerForBuild, String containerImageForBuild, String codeMountDirectory, String& publishLocation, String& zipArchivePath) in C:\build\src\Amazon.Lambda.Tools\LambdaPackager.cs:line 265
   at Amazon.Lambda.Tools.Commands.PackageCommand.PerformActionAsync() in C:\build\src\Amazon.Lambda.Tools\Commands\PackageCommand.cs:line 259
   at Amazon.Common.DotNetCli.Tools.Commands.BaseCommand`1.ExecuteAsync() in C:\build\src\Amazon.Common.DotNetCli.Tools\Commands\BaseCommand.cs:line 60

Previous version which loaded 5.13.2 did not have this problem:

Run dotnet tool install -g Amazon.Lambda.Tools
You can invoke the tool using the following command: dotnet-lambda
Tool 'amazon.lambda.tools' (version '5.13.2') was successfully installed.
Amazon Lambda Tools for .NET Core applications (5.13.2)
Project Home: https://github.com/aws/aws-extensions-for-dotnet-cli, https://github.com/aws/aws-lambda-dotnet
	
Found /etc/os-release
Executing publish command
... invoking 'dotnet publish', working folder '/home/runner/work/app/bin/Release/net9.0/publish'
... dotnet publish "/home/runner/work/app" --output "/home/runner/work/app/bin/Release/net9.0/publish" --configuration "Release" --framework "net9.0" --self-contained true /p:GenerateRuntimeConfigurationFiles=true --runtime linux-x64
... publish:   Determining projects to restore...
....... >>>
Changed permissions on published file (chmod +rx System.Runtime.Serialization.Xml.dll).
Changed permissions on published file (chmod +rx System.ComponentModel.TypeConverter.dll).
Changed permissions on published file (chmod +rx System.Reflection.Primitives.dll).
Zipping publish folder /home/runner/work/app/bin/Release/net9.0/publish to /home/runner/work/app/output/lambda/app.zip
Creating directory /home/runner/work/app/output/lambda

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Compile

Current Behavior

Unknown error executing command: The value cannot be an empty string. (Parameter 'path')
at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
at System.IO.Path.GetFullPath(String path)
at Amazon.Lambda.Tools.LambdaPackager.CreateApplicationBundle(LambdaToolsDefaults defaults, IToolLogger logger, String workingDirectory, String projectLocation, String configuration, String targetFramework, String msbuildParameters, String architecture, Boolean disableVersionCheck, LayerPackageInfo layerPackageInfo, Boolean isNativeAot, Nullable1 useContainerForBuild, String containerImageForBuild, String codeMountDirectory, String& publishLocation, String& zipArchivePath) in C:\build\src\Amazon.Lambda.Tools\LambdaPackager.cs:line 265 at Amazon.Lambda.Tools.Commands.PackageCommand.PerformActionAsync() in C:\build\src\Amazon.Lambda.Tools\Commands\PackageCommand.cs:line 259 at Amazon.Common.DotNetCli.Tools.Commands.BaseCommand1.ExecuteAsync() in C:\build\src\Amazon.Common.DotNetCli.Tools\Commands\BaseCommand.cs:line 60

Reproduction Steps

Build previously running 5.x to 6.x, fails.

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

6.0.0

Targeted .NET Platform

.NET 9

Operating System and version

Linux Git Runner

[normj]

@carter-broom I'm trying to reproduce the problem. Can you share the parameters you are using in the dotnet package command and if there are any values in the the aws-lambda-tools-defaults.json file? Also describe from what directory it is being run and the directory that has code to package in?

[carter-broom]

I'm using the following command in the Action:

dotnet lambda package ./output/lambda/${{ matrix.project.projectName }}.zip -pl ./${{ matrix.project.projectName }}/ -f net9.0 -pt zip --msbuild-params "${{ matrix.project.buildParams }}"

Which results in:

dotnet lambda package ./output/lambda/MyProject.zip -pl ./MyProject/ -f net9.0 -pt zip --msbuild-params ""
^ this failing one does not have any buildParams, but others have --self-contained true

I am able to pin 5.13.0 and continue to build normally.

{
  "configuration": "Release",
  "function-runtime": "provided.al2",
  "function-memory-size": 1024,
  "function-timeout": 30,
  "function-handler": "MyProject",
  "msbuild-parameters": "--self-contained true",
  "framework": "net9.0"
}

[normj]

Thanks for the info and your patience.

[carter-broom]

Not a problem - I wouldn't have noticed if not for the auto-update, pinning the previous version for us is fine until we upgrade to net10.0

[normj]

Ah I see what is going wrong. The TLDR is we aren't defensive enough and you have a typo with the --msbuild-params should have been --msbuild-parameters. By weird unfortunate flow of logic the "" after the incorrect --msbuild-params is getting mistaken as the argument getting set for the output package.

The reason this broke in the new major version was we added support for multiple arguments with the second being a C# file-based function for supporting that new .NET 10 feature.

I'll add some some defensiveness but you can move forward to the new major version if you change to --msbuild-parameters.

[carter-broom]

Ah! Thank you for the catch, apologies for the use of time.

[normj]

@carter-broom No worries I still views this as our bug for incorrectly using the empty string value for --msbuild-params for the package name. I update this PR where I addressed a different regression to include the defensive code so you wouldn't have gotten into this issue.

[normj]

Version 6.0.1 is released with the fix. Thanks again for reporting the issue and sorry for the inconvenience.