Skip to content

Commit e5c7df0

Browse files
bchamppyaythomas
authored andcommitted
chore: remove local runner lambda client (#201)
1 parent 7617791 commit e5c7df0

File tree

6 files changed

+15
-7999
lines changed

6 files changed

+15
-7999
lines changed

src/aws_durable_execution_sdk_python/botocore/data/lambdainternal-local/2015-03-31/service-2.json

Lines changed: 0 additions & 7865 deletions
This file was deleted.

src/aws_durable_execution_sdk_python/execution.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ class DurableExecutionInvocationInput:
9797
durable_execution_arn: str
9898
checkpoint_token: str
9999
initial_execution_state: InitialExecutionState
100-
is_local_runner: bool
101100

102101
@staticmethod
103102
def from_dict(
@@ -109,15 +108,13 @@ def from_dict(
109108
initial_execution_state=InitialExecutionState.from_dict(
110109
input_dict.get("InitialExecutionState", {})
111110
),
112-
is_local_runner=input_dict.get("LocalRunner", False),
113111
)
114112

115113
def to_dict(self) -> MutableMapping[str, Any]:
116114
return {
117115
"DurableExecutionArn": self.durable_execution_arn,
118116
"CheckpointToken": self.checkpoint_token,
119117
"InitialExecutionState": self.initial_execution_state.to_dict(),
120-
"LocalRunner": self.is_local_runner,
121118
}
122119

123120

@@ -139,7 +136,6 @@ def from_durable_execution_invocation_input(
139136
durable_execution_arn=invocation_input.durable_execution_arn,
140137
checkpoint_token=invocation_input.checkpoint_token,
141138
initial_execution_state=invocation_input.initial_execution_state,
142-
is_local_runner=invocation_input.is_local_runner,
143139
service_client=service_client,
144140
)
145141

@@ -237,15 +233,12 @@ def wrapper(event: Any, context: LambdaContext) -> MutableMapping[str, Any]:
237233
)
238234
raise ExecutionError(msg) from e
239235

240-
# Local runner always uses its own client, otherwise use custom or default
241-
if invocation_input.is_local_runner:
242-
service_client = LambdaClient.initialize_local_runner_client()
243-
else:
244-
service_client = (
245-
LambdaClient(client=boto3_client)
246-
if boto3_client is not None
247-
else LambdaClient.initialize_from_env()
248-
)
236+
# Use custom client if provided, otherwise initialize from environment
237+
service_client = (
238+
LambdaClient(client=boto3_client)
239+
if boto3_client is not None
240+
else LambdaClient.initialize_from_env()
241+
)
249242

250243
raw_input_payload: str | None = (
251244
invocation_input.initial_execution_state.get_input_payload()

src/aws_durable_execution_sdk_python/lambda_service.py

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -951,33 +951,6 @@ def load_preview_botocore_models() -> None:
951951
Path(__file__).parent.joinpath("botocore", "data")
952952
)
953953

954-
@staticmethod
955-
def initialize_local_runner_client() -> LambdaClient:
956-
endpoint = os.getenv(
957-
"DURABLE_LOCAL_RUNNER_ENDPOINT", "http://host.docker.internal:5000"
958-
)
959-
region = os.getenv("DURABLE_LOCAL_RUNNER_REGION", "us-west-2")
960-
961-
# The local runner client needs execute-api as the signing service name,
962-
# so we have a second `lambdainternal-local` boto model with this.
963-
LambdaClient.load_preview_botocore_models()
964-
client = boto3.client(
965-
"lambdainternal-local",
966-
endpoint_url=endpoint,
967-
region_name=region,
968-
config=Config(
969-
connect_timeout=5,
970-
read_timeout=50,
971-
),
972-
)
973-
974-
logger.debug(
975-
"Initialized lambda client with endpoint: '%s', region: '%s'",
976-
endpoint,
977-
region,
978-
)
979-
return LambdaClient(client=client)
980-
981954
@staticmethod
982955
def initialize_from_env() -> LambdaClient:
983956
LambdaClient.load_preview_botocore_models()

tests/e2e/execution_int_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def my_handler(event, context: DurableContext) -> list[str]:
6868
"aws_durable_execution_sdk_python.execution.LambdaClient"
6969
) as mock_client_class:
7070
mock_client = Mock()
71-
mock_client_class.initialize_local_runner_client.return_value = mock_client
71+
mock_client_class.initialize_from_env.return_value = mock_client
7272

7373
# Mock the checkpoint method to track calls
7474
checkpoint_calls = []
@@ -154,7 +154,7 @@ def my_handler(event, context: DurableContext):
154154
"aws_durable_execution_sdk_python.execution.LambdaClient"
155155
) as mock_client_class:
156156
mock_client = Mock()
157-
mock_client_class.initialize_local_runner_client.return_value = mock_client
157+
mock_client_class.initialize_from_env.return_value = mock_client
158158

159159
# Mock the checkpoint method to track calls
160160
checkpoint_calls = []
@@ -255,7 +255,7 @@ def my_handler(event, context):
255255
"aws_durable_execution_sdk_python.execution.LambdaClient"
256256
) as mock_client_class:
257257
mock_client = Mock()
258-
mock_client_class.initialize_local_runner_client.return_value = mock_client
258+
mock_client_class.initialize_from_env.return_value = mock_client
259259

260260
# Mock the checkpoint method to track calls
261261
checkpoint_calls = []
@@ -361,7 +361,7 @@ def my_handler(event, context: DurableContext):
361361
"aws_durable_execution_sdk_python.execution.LambdaClient"
362362
) as mock_client_class:
363363
mock_client = Mock()
364-
mock_client_class.initialize_local_runner_client.return_value = mock_client
364+
mock_client_class.initialize_from_env.return_value = mock_client
365365

366366
# Mock the checkpoint method to raise an error (using RuntimeError as a generic exception)
367367
def mock_checkpoint_failure(
@@ -424,7 +424,7 @@ def my_handler(event: Any, context: DurableContext):
424424
"aws_durable_execution_sdk_python.execution.LambdaClient"
425425
) as mock_client_class:
426426
mock_client = Mock()
427-
mock_client_class.initialize_local_runner_client.return_value = mock_client
427+
mock_client_class.initialize_from_env.return_value = mock_client
428428

429429
# Mock the checkpoint method to track calls
430430
checkpoint_calls = []

0 commit comments

Comments
 (0)