Skip to content

chore(cdk): clean no-magic-numbers baseline and flip rule to error (#258 follow-up) #312

@krokoko

Description

@krokoko

Follow-up to #258 / PR #310.

PR #310 enabled @typescript-eslint/no-magic-numbers in cdk/ as advisory warn (~162 baseline hits). CLI and agent baselines were cleaned and the rules are blocking there; CDK was intentionally deferred.

Goal

Clean the CDK magic-number baseline and flip cdk/eslint.config.mjs from 'warn' to 'error' (matching cli/eslint.config.mjs).

Acceptance criteria

  • All existing @typescript-eslint/no-magic-numbers violations in cdk/src/** are fixed (promote to named module constants, or to contracts/constants.json when values must agree across Python/TypeScript).
  • cdk/eslint.config.mjs sets @typescript-eslint/no-magic-numbers to 'error'.
  • mise //cdk:eslint exits 0 with 0 warnings/errors for magic numbers.
  • mise run build green end-to-end.

Notes

Metadata

Metadata

Assignees

Labels

approvedWhen an issue has been approved and ready

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions