Skip to content

Commit 24ec51d

Browse files
committed
checkov findings
1 parent 50a1b97 commit 24ec51d

File tree

5 files changed

+5
-10
lines changed

5 files changed

+5
-10
lines changed

aws_sra_examples/solutions/cloudtrail/cloudtrail_org/templates/sra-cloudtrail-org-bucket.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ Resources:
218218

219219
rOrganizationCloudTrailS3BucketSecret:
220220
Type: AWS::SecretsManager::Secret
221-
# checkov:skip=CKV_SECRET_6 Base64:High Entropy String
222221
Condition: cCreateSecret
223222
Metadata:
224223
checkov:
@@ -228,7 +227,7 @@ Resources:
228227
Properties:
229228
Name: sra/cloudtrail_org_s3_bucket
230229
Description: Organization CloudTrail S3 Bucket
231-
SecretString: !Sub '{"OrganizationCloudTrailS3Bucket":"${rOrgTrailBucket}"}'
230+
SecretString: !Sub '{"OrganizationCloudTrailS3Bucket":"${rOrgTrailBucket}"}' # checkov:skip=CKV_SECRET_6 Base64
232231
KmsKeyId: !Ref pSRASecretsKeyAliasArn
233232
Tags:
234233
- Key: sra-solution

aws_sra_examples/solutions/cloudtrail/cloudtrail_org/templates/sra-cloudtrail-org-kms.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ Resources:
151151

152152
rOrganizationCloudTrailKeySecret:
153153
Type: AWS::SecretsManager::Secret
154-
# checkov:skip=CKV_SECRET_6:Base64 High Entropy String
155154
Condition: cCreateSecret
156155
Metadata:
157156
checkov:
@@ -161,7 +160,7 @@ Resources:
161160
Properties:
162161
Name: sra/cloudtrail_org_key_arn
163162
Description: Organization CloudTrail KMS Key ARN
164-
SecretString: !Sub '{"OrganizationCloudTrailKeyArn":"${rOrganizationCloudTrailKey.Arn}"}'
163+
SecretString: !Sub '{"OrganizationCloudTrailKeyArn":"${rOrganizationCloudTrailKey.Arn}"}' # checkov:skip=CKV_SECRET_6 Base64
165164
KmsKeyId: !Ref pSRASecretsKeyAliasArn
166165
Tags:
167166
- Key: sra-solution

aws_sra_examples/solutions/config/config_org/templates/sra-config-org-delivery-kms-key.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ Resources:
133133

134134
rConfigDeliveryKeySecret:
135135
Type: AWS::SecretsManager::Secret
136-
# checkov:skip=CKV_SECRET_6:Base64 High Entropy String
137136
Condition: cCreateSecret
138137
Metadata:
139138
checkov:
@@ -143,7 +142,7 @@ Resources:
143142
Properties:
144143
Name: sra/config_org_delivery_key_arn
145144
Description: Config Delivery KMS Key ARN
146-
SecretString: !Sub '{"ConfigDeliveryKeyArn":"${rConfigDeliveryKey.Arn}"}'
145+
SecretString: !Sub '{"ConfigDeliveryKeyArn":"${rConfigDeliveryKey.Arn}"}' # checkov:skip=CKV_SECRET_6 Base64
147146
KmsKeyId: !Ref pSRASecretsKeyAliasArn
148147
Tags:
149148
- Key: sra-solution

aws_sra_examples/solutions/guardduty/guardduty_org/templates/sra-guardduty-org-delivery-kms-key.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ Resources:
133133

134134
rGuardDutyDeliveryKeySecret:
135135
Type: AWS::SecretsManager::Secret
136-
# checkov:skip=CKV_SECRET_6 Base64:High Entropy String
137136
Condition: cCreateSecret
138137
Metadata:
139138
checkov:
@@ -143,7 +142,7 @@ Resources:
143142
Properties:
144143
Name: sra/guardduty_org_delivery_key_arn
145144
Description: GuardDuty Delivery KMS Key ARN
146-
SecretString: !Sub '{"GuardDutyDeliveryKeyArn":"${rGuardDutyDeliveryKey.Arn}"}'
145+
SecretString: !Sub '{"GuardDutyDeliveryKeyArn":"${rGuardDutyDeliveryKey.Arn}"}' # checkov:skip=CKV_SECRET_6 Base64
147146
KmsKeyId: !Ref pSRASecretsKeyAliasArn
148147
Tags:
149148
- Key: sra-solution

aws_sra_examples/solutions/macie/macie_org/templates/sra-macie-org-delivery-kms-key.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ Resources:
139139

140140
rMacieOrgDeliveryKeySecret:
141141
Type: AWS::SecretsManager::Secret
142-
# checkov:skip=CKV_SECRET_6 Base64:High Entropy String
143142
Condition: cCreateSecret
144143
Metadata:
145144
checkov:
@@ -149,7 +148,7 @@ Resources:
149148
Properties:
150149
Name: sra/macie_org_delivery_key_arn
151150
Description: Macie Delivery KMS Key ARN
152-
SecretString: !Sub '{"MacieOrgDeliveryKeyArn":"${rMacieOrgDeliveryKey.Arn}"}'
151+
SecretString: !Sub '{"MacieOrgDeliveryKeyArn":"${rMacieOrgDeliveryKey.Arn}"}' # checkov:skip=CKV_SECRET_6 Base64
153152
KmsKeyId: !Ref pSRASecretsKeyAliasArn
154153
Tags:
155154
- Key: sra-solution

0 commit comments

Comments
 (0)