fix: react16 17 need install even in dev mode

avennn · avennn · commit b5d8a2fbbe48 · 2023-05-30T20:25:12.000+08:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-source-debugger",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "description": "A tool for quickly setting up the environment of debugging React source code.",
   "main": "src/index.js",
   "type": "module",
diff --git a/src/commands/init.js b/src/commands/init.js
@@ -186,7 +186,7 @@ async function prepareReact({ dir: reactDir, version: reactVersion, mode }) {
   }
 
   // since react17 react16 production reguire "object-assign", we need to install deps
-  if (['16', '17'].includes(matchedVersion.split('.')[0]) && mode === 'production') {
+  if (['16', '17'].includes(matchedVersion.split('.')[0])) {
     hint.doing(`Installing react v${matchedVersion} deps.`);
     cd(reactDir);
     await spawnRunCommand(

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-source-debugger",`
`3`		`- "version": "1.1.3",`
	`3`	`+ "version": "1.1.4",`
`4`	`4`	`"description": "A tool for quickly setting up the environment of debugging React source code.",`
`5`	`5`	`"main": "src/index.js",`
`6`	`6`	`"type": "module",`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ async function prepareReact({ dir: reactDir, version: reactVersion, mode }) {`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`// since react17 react16 production reguire "object-assign", we need to install deps`
`189`		`- if (['16', '17'].includes(matchedVersion.split('.')[0]) && mode === 'production') {`
	`189`	`+ if (['16', '17'].includes(matchedVersion.split('.')[0])) {`
`190`	`190`	hint.doing(`Installing react v${matchedVersion} deps.`);
`191`	`191`	`cd(reactDir);`
`192`	`192`	`await spawnRunCommand(`