feat: package shell completions into DEB, RPM, and APK#693
Open
ivanauth wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 43.77% 43.77%
=======================================
Files 38 38
Lines 6193 6193
=======================================
Hits 2711 2711
Misses 3201 3201
Partials 281 281 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jzelinskie
reviewed
May 22, 2026
| return err | ||
| } | ||
|
|
||
| rootCmd := cmd.InitialiseRootCmd(cobrazerolog.New()) |
Member
There was a problem hiding this comment.
I have a feeling that this is more brittle than reconfiguring goreleaser to run this in a pre-publish hook:
zed completion bash > ./completions/zed.bash
zed completion zsh > ./completions/zed.zsh
zed completion fish > ./completions/zed.fish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Gen.Completionsmage target that generates bash/zsh/fish completion scripts via Cobra's built-in generators, and wires goreleaser to produce them before each build and install them into the standard system paths for DEB, RPM, and APK packages.Fixes #345