Skip to content

get with prefix#14

Open
texnicii wants to merge 2 commits into
aternosorg:masterfrom
texnicii:get-prefix
Open

get with prefix#14
texnicii wants to merge 2 commits into
aternosorg:masterfrom
texnicii:get-prefix

Conversation

@texnicii

@texnicii texnicii commented Apr 8, 2025

Copy link
Copy Markdown

Added request with prefix which returns Generator<Mvccpb\KeyValue>

// example 
foreach ($client->getWithPrefix('/some-namespace') as $val) {
    echo $val->getKey() . " -> " . $val->getValue() . "\n";
}

@CLAassistant

CLAassistant commented Apr 8, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@texnicii texnicii mentioned this pull request Apr 8, 2025

@matthi4s matthi4s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! You haven't updated the ShardedClient yet, but with the changed ClientInterface, that would cause fatal errors. You probably have to request all keys from all clients for the ShardedClient.

Comment thread src/Client.php Outdated
Comment thread src/ClientInterface.php Outdated
@texnicii texnicii requested a review from matthi4s April 18, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants