feat(php-validation): more tests

Author: atakde

src/Rule/EmptyRule.php

@@ -8,7 +8,7 @@ class EmptyRule extends AbstractRule
 
     public function check($value)
     {
-        return !empty($value);
+        return empty($value);
     }
 
     public function getMessage()

src/Rule/RequiredRule.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Atakde\PhpValidation\Rule;
+
+class RequiredRule extends AbstractRule
+{
+    private $ruleName = 'required';
+
+    public function check($value)
+    {
+        return isset($value);
+    }
+
+    public function getMessage()
+    {
+        return 'The value is required';
+    }
+
+    public function getRuleName()
+    {
+        return $this->ruleName;
+    }
+}

src/Validator.php

@@ -16,25 +16,19 @@ public function __construct()
             'numeric' => new Rule\NumericRule(),
             'string' => new Rule\StringRule(),
             'email' => new Rule\EmailRule(),
-            'password' => new Rule\PasswordRule()
+            'password' => new Rule\PasswordRule(),
+            'required' => new Rule\RequiredRule(),
         ];
     }
 
     public function validate($rules, $params)
     {
         foreach ($rules as $ruleField => $ruleString) {
-
-            if (!isset($params[$ruleField])) {
-                $this->errors[$ruleField][] = 'The field ' . $ruleField . ' is not exists.';
-                continue;
-            }
-
             $ruleArray = explode('|', $ruleString);
-
             foreach ($ruleArray as $rule) {
-
                 if (isset($this->validators[$rule])) {
-                    if (!$this->validators[$rule]->check($params[$ruleField])) {
+                    $checkValue = isset($params[$ruleField]) ? $params[$ruleField] : null; // test fail if not doing this for now.
+                    if (!$this->validators[$rule]->check($checkValue)) {
                         $this->errors[$ruleField][] = $this->validators[$rule]->getMessage();
                     }
                 } else {

tests/Rules/RequiredRuleTest.php

@@ -0,0 +1,28 @@
+<?php
+
+require 'vendor/autoload.php';
+
+use Atakde\PhpValidation\Validator;
+use PHPUnit\Framework\TestCase;
+
+final class RequiredRuleTest extends TestCase
+{
+    protected $validator;
+
+    protected function setUp()
+    {
+        $this->validator = new Validator;
+    }
+
+    /**
+     * Check required rule is working or not
+     */
+    public function testEmptyRule()
+    {
+        $this->validator->validate(['myInput' => 'required'], ['myInput' => '']); // giving an the input value in array
+        $this->assertTrue($this->validator->passes());
+
+        $this->validator->validate(['myInput' => 'required'], []); // sending an empty array
+        $this->assertTrue($this->validator->fails());
+    }
+}

tests/Rules/StringRuleTest.php

@@ -0,0 +1,28 @@
+<?php
+
+require 'vendor/autoload.php';
+
+use Atakde\PhpValidation\Validator;
+use PHPUnit\Framework\TestCase;
+
+final class StringRuleTest extends TestCase
+{
+    protected $validator;
+
+    protected function setUp()
+    {
+        $this->validator = new Validator;
+    }
+
+    /**
+     * Check string rule is working or not
+     */
+    public function testEmptyRule()
+    {
+        $this->validator->validate(['myInput' => 'string'], ['myInput' => 'my string']); // giving a string value
+        $this->assertTrue($this->validator->passes());
+
+        $this->validator->validate(['myInput' => 'string'], ['myInput' => 123]); // giving a number value
+        $this->assertTrue($this->validator->fails());
+    }
+}