From 75786e9a7138125e567a56537c33dd635aee7a84 Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Tue, 26 Aug 2025 10:43:54 +0200 Subject: [PATCH] C++: Revert changes to `cpp/constant-array-overflow` It is not clear that this does what we want here, and the query is severly broken in any case. --- .../Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql b/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql index c74936e7367b..b7b2de6000ae 100644 --- a/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql +++ b/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql @@ -168,9 +168,9 @@ module ArrayAddressToDerefConfig implements DataFlow::StateConfigSig { ) } - predicate isBarrierIn(DataFlow::Node node, FlowState state) { isSource(node, state) } + predicate isBarrierIn(DataFlow::Node node) { isSource(node, _) } - predicate isBarrierOut(DataFlow::Node node, FlowState state) { isSink(node, state) } + predicate isBarrierOut(DataFlow::Node node) { isSink(node, _) } predicate isAdditionalFlowStep( DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2