SAM boards stop compiling due to way of handling params with spaces on different OSs. Fixed

Author: Federico Fissore

arduino-core/src/processing/app/debug/Compiler.java

@@ -54,6 +54,7 @@
 import processing.app.legacy.PApplet;
 import processing.app.packages.LegacyUserLibrary;
 import processing.app.packages.UserLibrary;
+import processing.app.tools.ArgumentsWithSpaceAwareCommandLine;
 
 public class Compiler implements MessageConsumer {
 
@@ -319,10 +320,10 @@ protected void size(PreferencesMap prefs) throws RunnerException {
       if (maxDataSize > 0) {
         System.out
             .println(I18n
-                .format(
-                        _("Global variables use {0} bytes ({2}%%) of dynamic memory, leaving {3} bytes for local variables. Maximum is {1} bytes."),
-                        dataSize, maxDataSize, dataSize * 100 / maxDataSize,
-                        maxDataSize - dataSize));
+                    .format(
+                            _("Global variables use {0} bytes ({2}%%) of dynamic memory, leaving {3} bytes for local variables. Maximum is {1} bytes."),
+                            dataSize, maxDataSize, dataSize * 100 / maxDataSize,
+                            maxDataSize - dataSize));
       } else {
         System.out.println(I18n
             .format(_("Global variables use {0} bytes of dynamic memory."), dataSize));
@@ -736,9 +737,9 @@ public void stop() {
       }
     });
 
-    CommandLine commandLine = new CommandLine(command[0]);
+    CommandLine commandLine = new ArgumentsWithSpaceAwareCommandLine(command[0]);
     for (int i = 1; i < command.length; i++) {
-      commandLine.addArgument(command[i]);
+      commandLine.addArgument(command[i], false);
     }
 
     int result;

arduino-core/src/processing/app/tools/ArgumentsWithSpaceAwareCommandLine.java

@@ -0,0 +1,32 @@
+package processing.app.tools;
+
+import org.apache.commons.exec.CommandLine;
+import processing.app.BaseNoGui;
+import processing.app.Platform;
+import processing.app.helpers.OSUtils;
+
+import java.io.File;
+
+public class ArgumentsWithSpaceAwareCommandLine extends CommandLine {
+
+  public ArgumentsWithSpaceAwareCommandLine(String executable) {
+    super(executable);
+  }
+
+  public ArgumentsWithSpaceAwareCommandLine(File executable) {
+    super(executable);
+  }
+
+  public ArgumentsWithSpaceAwareCommandLine(CommandLine other) {
+    super(other);
+  }
+
+  @Override
+  public CommandLine addArgument(String argument, boolean handleQuoting) {
+    if (argument.contains(" ") && OSUtils.isWindows()) {
+      argument = argument.replaceAll("\"", "").replaceAll("'", "");
+    }
+
+    return super.addArgument(argument, handleQuoting);
+  }
+}