fix: display better pkg link for flagged group of split packages#691
Open
lahwaacz wants to merge 1 commit into
Open
fix: display better pkg link for flagged group of split packages#691lahwaacz wants to merge 1 commit into
lahwaacz wants to merge 1 commit into
Conversation
Fixes the issue pointed out in this comment: archlinux@2e28e98#commitcomment-185933020 When a split package has pkgbase name that is alphabetically after a pkgname of another package, we need a sorting trick to display a link to the correct package. This follows the behavior of the signoff table, only without the PackageSignoffGroup class.
Contributor
Author
|
cc @eworm-de |
Contributor
|
Great, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue pointed out in this comment:
2e28e98#commitcomment-185933020
When a split package has pkgbase name that is alphabetically after a pkgname of another package, we need a sorting trick to display a link to the correct package. This follows the behavior of the signoff table, only without the PackageSignoffGroup class.