fixed VPack parsing (issue #80)

Author: Mark

ChangeLog

@@ -1,6 +1,7 @@
 v4.1.4 (2016-11-xx)
 ---------------------------
 * added VPack serializer/de-serializer for java.util.UUID
+* fixed VPack parsing (issue #80)
 
 v4.1.3 (2016-11-22)
 ---------------------------

src/main/java/com/arangodb/velocypack/VPackBuilder.java

@@ -721,7 +721,7 @@ protected VPackBuilder close(final boolean sort)
 		final int offsetSize;
 		// can be 1, 2, 4 or 8 for the byte width of the offsets,
 		// the byte length and the number of subvalues:
-		if ((size - 1 - tos) + in.size() - 6 <= 0xff) {
+		if (size - tos + in.size() - 6 <= 0xff) {
 			// We have so far used _pos - tos bytes, including the reserved 8
 			// bytes for byte length and number of subvalues. In the 1-byte
 			// number

src/test/java/com/arangodb/velocypack/VPackBuilderTest.java

@@ -911,4 +911,25 @@ public void addBitInteger() {
 		assertThat(vpack.getAsBigInteger(), is(value));
 	}
 
+	@Test
+	public void objectWithByteSize256() {
+		final StringBuilder aa = new StringBuilder();
+		final int stringLength = 231;
+		for (int i = 0; i < stringLength; ++i) {
+			aa.append("a");
+		}
+		final String foo = "foo";
+		final String bar1 = "bar1";
+		final String bar2 = "bar2";
+		final VPackSlice vpack = new VPackBuilder().add(ValueType.OBJECT).add(foo, ValueType.OBJECT).add(bar2, "")
+				.add(bar1, aa.toString()).close().close().slice();
+
+		assertThat(vpack.isObject(), is(true));
+		assertThat(vpack.get(foo).isObject(), is(true));
+		assertThat(vpack.get(foo).get(bar1).isString(), is(true));
+		assertThat(vpack.get(foo).get(bar1).getLength(), is(stringLength));
+		assertThat(vpack.get(foo).get(bar2).isString(), is(true));
+		assertThat(vpack.get(foo).get(bar2).getLength(), is(0));
+	}
+
 }

src/test/java/com/arangodb/velocypack/VPackUtil.java

@@ -0,0 +1,42 @@
+/*
+ * DISCLAIMER
+ *
+ * Copyright 2016 ArangoDB GmbH, Cologne, Germany
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * Copyright holder is ArangoDB GmbH, Cologne, Germany
+ */
+
+package com.arangodb.velocypack;
+
+/**
+ * @author Mark - mark at arangodb.com
+ *
+ */
+public class VPackUtil {
+
+	private final static char[] hexArray = "0123456789ABCDEF".toCharArray();
+
+	public static String toHex(final VPackSlice vpack) {
+		final byte[] bytes = vpack.getRawVPack();
+		final char[] hexChars = new char[bytes.length * 2];
+		for (int j = 0; j < bytes.length; j++) {
+			final int v = bytes[j] & 0xFF;
+			hexChars[j * 2] = hexArray[v >>> 4];
+			hexChars[j * 2 + 1] = hexArray[v & 0x0F];
+		}
+		return new String(hexChars).replaceAll("(.{32})", "$1\n").replaceAll("(.{2})", "0x$1 ").toLowerCase();
+	}
+
+}