From 7e1a3dba545f3b9626e5afb2bf0e7c49a979ab76 Mon Sep 17 00:00:00 2001 From: Joel Menchavez Date: Sun, 5 Apr 2026 22:52:29 -0700 Subject: [PATCH 1/3] fix/ADFA-1123 Better error message for missing assets zip --- .../com/itsaky/androidide/assets/AssetsInstallationHelper.kt | 3 ++- .../java/com/itsaky/androidide/assets/SplitAssetsInstaller.kt | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt b/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt index 55b5e21a73..72c2999448 100644 --- a/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt +++ b/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt @@ -23,6 +23,7 @@ import org.adfa.constants.LOCAL_MAVEN_REPO_ARCHIVE_ZIP_NAME import org.adfa.constants.TEMPLATE_CORE_ARCHIVE import org.slf4j.LoggerFactory import com.itsaky.androidide.resources.R +import com.itsaky.androidide.utils.flashError import java.io.File import java.io.FileNotFoundException import java.io.IOException @@ -131,7 +132,7 @@ object AssetsInstallationHelper { true } catch (e: FileNotFoundException) { logger.error("ZIP file not found: {}", e.message) - onProgress(Progress("${e.message}")) + flashError("${e.message}") false } catch (e: ZipException) { logger.error("Invalid ZIP format: {}", e.message) diff --git a/app/src/main/java/com/itsaky/androidide/assets/SplitAssetsInstaller.kt b/app/src/main/java/com/itsaky/androidide/assets/SplitAssetsInstaller.kt index 935b69c585..542947560c 100644 --- a/app/src/main/java/com/itsaky/androidide/assets/SplitAssetsInstaller.kt +++ b/app/src/main/java/com/itsaky/androidide/assets/SplitAssetsInstaller.kt @@ -37,7 +37,8 @@ data object SplitAssetsInstaller : BaseAssetsInstaller() { ): Unit = withContext(Dispatchers.IO) { if (!Environment.SPLIT_ASSETS_ZIP.exists()) { - throw FileNotFoundException("Assets zip file not found at path: ${Environment.SPLIT_ASSETS_ZIP.path}") + throw FileNotFoundException("Assets zip file not found at path: ${Environment.SPLIT_ASSETS_ZIP.path}." + + " Please check Slack #qa-testing-builds channel for the latest version.") } zipFile = ZipFile(Environment.SPLIT_ASSETS_ZIP) From 7e1bbb83e52312821e7b7e3c1026495adfc5b39b Mon Sep 17 00:00:00 2001 From: Joel Menchavez Date: Sun, 5 Apr 2026 23:07:53 -0700 Subject: [PATCH 2/3] address possible empty flash error message --- .../com/itsaky/androidide/assets/AssetsInstallationHelper.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt b/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt index 72c2999448..f28732ca8f 100644 --- a/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt +++ b/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt @@ -132,7 +132,7 @@ object AssetsInstallationHelper { true } catch (e: FileNotFoundException) { logger.error("ZIP file not found: {}", e.message) - flashError("${e.message}") + flashError("File not found: ${e.message}") false } catch (e: ZipException) { logger.error("Invalid ZIP format: {}", e.message) From 15f3c4257c70f2dd9b823a08be8b3b63d0731e5d Mon Sep 17 00:00:00 2001 From: Joel Menchavez Date: Sun, 5 Apr 2026 23:09:20 -0700 Subject: [PATCH 3/3] format change --- .../com/itsaky/androidide/assets/AssetsInstallationHelper.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt b/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt index f28732ca8f..301b7ce1c1 100644 --- a/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt +++ b/app/src/main/java/com/itsaky/androidide/assets/AssetsInstallationHelper.kt @@ -132,7 +132,7 @@ object AssetsInstallationHelper { true } catch (e: FileNotFoundException) { logger.error("ZIP file not found: {}", e.message) - flashError("File not found: ${e.message}") + flashError("File not found - ${e.message}") false } catch (e: ZipException) { logger.error("Invalid ZIP format: {}", e.message)