Skip to content

Commit 9a5c8ad

Browse files
committed
ci: Use unified ^Checks regex in wait-for-checks gates
With every check now living under the single `Checks` workflow, the wait-for-checks regex in each manual_* workflow collapses to `^Checks` instead of enumerating `Code checks` / `Tests` / `Doc checks` separately.
1 parent f03d0f6 commit 9a5c8ad

4 files changed

Lines changed: 16 additions & 23 deletions

File tree

.github/workflows/manual_release_beta.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,18 @@ permissions:
1717

1818
jobs:
1919
wait_for_checks:
20-
# Verify that `Code checks` and `Tests` already completed successfully on the dispatch commit
21-
# (they run via `on_master.yaml` on every push to master). For the auto-dispatched path from
22-
# `on_master.yaml`, these are guaranteed by `needs:` already; this also gates manual dispatches.
23-
# TODO: switch from the PR branch to a tagged release once apify/workflows#238 is merged.
20+
# Gate the release on the `Checks` workflow already succeeding on this commit (run by `on_master.yaml`).
21+
# TODO: pin to a tag after apify/workflows#238 is merged.
2422
name: Wait for required checks
2523
runs-on: ubuntu-latest
2624
permissions:
2725
checks: read
2826
steps:
29-
- name: Wait for Code checks and Tests
27+
- name: Wait for checks
3028
uses: apify/workflows/wait-for-checks@wait-for-checks-action
3129
with:
3230
ref: ${{ github.sha }}
33-
check-regexp: '^(Code checks|Tests)'
31+
check-regexp: '^Checks'
3432

3533
release_prepare:
3634
name: Release prepare

.github/workflows/manual_release_docs.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,14 @@ jobs:
2727
runs-on: ubuntu-latest
2828

2929
steps:
30-
# Verify `Doc checks` already passed on the dispatch commit (they run via `on_master.yaml`
31-
# on every push to master). Skipped when this workflow is invoked via `workflow_call` from
32-
# another release workflow — the parent has already gated on the relevant checks.
33-
# TODO: switch from the PR branch to a tagged release once apify/workflows#238 is merged.
34-
- name: Wait for Doc checks
30+
# Gate manual dispatches on the `Checks` workflow already succeeding on this commit (run by `on_master.yaml`);
31+
# skipped when called from another workflow. TODO: pin to a tag after apify/workflows#238 is merged.
32+
- name: Wait for checks
3533
if: github.event_name == 'workflow_dispatch'
3634
uses: apify/workflows/wait-for-checks@wait-for-checks-action
3735
with:
3836
ref: ${{ github.sha }}
39-
check-regexp: '^Doc checks'
37+
check-regexp: '^Checks'
4038

4139
- name: Checkout repository
4240
uses: actions/checkout@v6

.github/workflows/manual_release_stable.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,18 @@ permissions:
3030

3131
jobs:
3232
wait_for_checks:
33-
# Verify that `Code checks` and `Tests` already completed successfully on the dispatch commit
34-
# (they run via `on_master.yaml` on every push to master). Avoids re-running them on release.
35-
# TODO: switch from the PR branch to a tagged release once apify/workflows#238 is merged.
33+
# Gate the release on the `Checks` workflow already succeeding on this commit (run by `on_master.yaml`).
34+
# TODO: pin to a tag after apify/workflows#238 is merged.
3635
name: Wait for required checks
3736
runs-on: ubuntu-latest
3837
permissions:
3938
checks: read
4039
steps:
41-
- name: Wait for Code checks and Tests
40+
- name: Wait for checks
4241
uses: apify/workflows/wait-for-checks@wait-for-checks-action
4342
with:
4443
ref: ${{ github.sha }}
45-
check-regexp: '^(Code checks|Tests)'
44+
check-regexp: '^Checks'
4645

4746
release_prepare:
4847
name: Release prepare

.github/workflows/manual_version_docs.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,14 @@ jobs:
3939
checks: read
4040

4141
steps:
42-
# Verify `Doc checks` already passed on the dispatch commit (they run via `on_master.yaml`
43-
# on every push to master). Skipped when invoked via `workflow_call` from the stable release —
44-
# the parent has already gated on the relevant checks.
45-
# TODO: switch from the PR branch to a tagged release once apify/workflows#238 is merged.
46-
- name: Wait for Doc checks
42+
# Gate manual dispatches on the `Checks` workflow already succeeding on this commit (run by `on_master.yaml`);
43+
# skipped when called from another workflow. TODO: pin to a tag after apify/workflows#238 is merged.
44+
- name: Wait for checks
4745
if: github.event_name == 'workflow_dispatch'
4846
uses: apify/workflows/wait-for-checks@wait-for-checks-action
4947
with:
5048
ref: ${{ github.sha }}
51-
check-regexp: '^Doc checks'
49+
check-regexp: '^Checks'
5250

5351
- name: Checkout repository
5452
uses: actions/checkout@v6

0 commit comments

Comments
 (0)