Comments. ISSUE: Xalan-test is currently relying on our having run the package target to avoid version numbers in jarfile names, which keeps test from running successfully pre-package... but that's when it _wants_ to run, so package can copy most recent results into the source archive as documentation. Easiest fix would be to change xalan-test to use ../xalan-java/* (the only form of wildcard that Java classpaths support). Assuming we do decided to fix this; xalan-java's ant build did *not* always run smoketests.

Author: kubycsolutions

integration-tests/pom.xml

@@ -62,6 +62,11 @@
       </plugin>
 
       <!-- Invoke sibling xalan-test project for conformance tests?
+	   The Ant build for Xalan did *not* do so automagically,
+	   though it had convenience targets for doing so an
+	   for warning if the test suite was not where it was
+	   expected to be.
+
            Ideally we want that done before packaging, so a current
            conformance run (at least the essential targets) is run
            befroe the tests and results are bundled into the
@@ -95,9 +100,11 @@
            -lib. It isn't as pretty as using the <antrun> task would
            be.  But it appears to do the job.
 
-           It is actually unclear that this automatic xalan-test run
-           was being done by the ant build. If it wasn't, we could
-           defer this... but it's desirable for source packaging if/when.
+           Since the ant build packaged but did not normally run the
+           tests (or check for a successful run having been done), we
+           don't actually have to do this right now. It's desirable if
+           the test source includes proof of recent run against that
+           source, but deferrable.
       -->
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
@@ -106,7 +113,7 @@
         <executions>
           <execution>
             <id>xalan-test attempt</id>
-            <phase>pre-</phase>
+            <phase>pre-package</phase>
             <goals>
               <goal>exec</goal>
             </goals>