SOLR-18263 improve luke request handler distrib test performance#4455
Open
kotman12 wants to merge 7 commits into
Open
SOLR-18263 improve luke request handler distrib test performance#4455kotman12 wants to merge 7 commits into
kotman12 wants to merge 7 commits into
Conversation
dsmiley
approved these changes
May 22, 2026
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
shallow review. I like the javadocs. thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18263
Description
LukeRequestHandlerDistribTest is exceptionally slow, mostly because it instantiates lots of jetty servers. This was especially bad for the "sparse shard" test cases.
Solution
Tests that didn't rely on BaseDistributedSearchTestCase machinery were moved to LukeHandlerCloudTest. The remaining tests were pooled whenever possible. The "sparse shard" test cases were made less sparse by decreasing their shard count and pooling them into one test.