From 9154e0a9bc1608fd8e1e5d064d2e3fdb5e36d963 Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Wed, 10 Apr 2024 22:24:17 +0800 Subject: [PATCH 1/2] ORC-1669: [C++] Deprecate HDFS support --- CMakeLists.txt | 2 +- c++/include/orc/OrcFile.hh | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1fb0e755d6..af5b9f406d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -42,7 +42,7 @@ option (ANALYZE_JAVA option (BUILD_LIBHDFSPP "Include LIBHDFSPP library in the build process" - ON) + OFF) option(BUILD_CPP_TESTS "Build the googletest unit tests" diff --git a/c++/include/orc/OrcFile.hh b/c++/include/orc/OrcFile.hh index 6e4a07bf7c..9af8748bc5 100644 --- a/c++/include/orc/OrcFile.hh +++ b/c++/include/orc/OrcFile.hh @@ -127,8 +127,9 @@ namespace orc { * @param path the uri of the file in HDFS * @param metrics the metrics of the reader */ - std::unique_ptr readHdfsFile(const std::string& path, - ReaderMetrics* metrics = nullptr); + [[deprecated("readHdfsFile is deprecated in 2.0.1 and will be removed in 2.1.0")]] std:: + unique_ptr + readHdfsFile(const std::string& path, ReaderMetrics* metrics = nullptr); /** * Create a reader to read the ORC file. From dbc8147c2854b6e248c83a59c7839b9212b2f64f Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Fri, 12 Apr 2024 12:56:08 +0800 Subject: [PATCH 2/2] refine message --- c++/include/orc/OrcFile.hh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/c++/include/orc/OrcFile.hh b/c++/include/orc/OrcFile.hh index 9af8748bc5..a9ad692d42 100644 --- a/c++/include/orc/OrcFile.hh +++ b/c++/include/orc/OrcFile.hh @@ -127,9 +127,8 @@ namespace orc { * @param path the uri of the file in HDFS * @param metrics the metrics of the reader */ - [[deprecated("readHdfsFile is deprecated in 2.0.1 and will be removed in 2.1.0")]] std:: - unique_ptr - readHdfsFile(const std::string& path, ReaderMetrics* metrics = nullptr); + [[deprecated("readHdfsFile is deprecated in 2.0.1")]] std::unique_ptr readHdfsFile( + const std::string& path, ReaderMetrics* metrics = nullptr); /** * Create a reader to read the ORC file.