netbeans terminal window: unable to delete known servers list

[wumpz]

Description

I use the terminal window a lot. Now my list of known servers has grown to a inconvinient size.

How do I delete this list of known servers? I would be nice to have a GUI possibility of deleting a known server configuration from Netbeans Terminal.

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow the Apache Software Foundation's Code of Conduct

[ShadowOfLies]

This ticket might be misleading, since to me it seems that it is referencing the known hosts associated with ssh connections. Commonly presented as a message similar to Permanently added '18.XXX.XXX.38' (ED25519) to the list of known hosts. during a first connection.

If, however, my understanding is correct, I would consider this out of scope of the IDE. As far as I know, the terminal offers a wrapper to the system terminal, one of which is cygwin on Windows. This means that something like the ssh config files should remain under OS or third party tool management.

Again, if I understand correctly, this involves managing the known_hosts file, usually located at ~/.ssh/known_hosts and should be managed through the proper tools/means and not through the IDE, unless an SSH terminal feature is added to specifically manage SSH connections.

If I've misunderstood, some clarity on the ticket could result in more interest to contribute.

[matthiasblaesing]

My understanding is, that the issue is about this dialog and the list of username/host pairs in the dropdown list:

that dialog can be invoked from the terminal window tab:

That list is not associated with the ssh known_hosts file. The code that manages that list can be found here:

netbeans/ide/dlight.nativeexecution/src/org/netbeans/modules/nativeexecution/api/util/ConnectionManager.java

Lines 187 to 224 in 3502830

	public List<ExecutionEnvironment> getRecentConnections() {
	synchronized (recentConnections) {
	return Collections.unmodifiableList(new ArrayList<>(recentConnections));
	}
	}
	/*package-local for test purposes*/ void updateRecentConnectionsList(ExecutionEnvironment execEnv) {
	synchronized (recentConnections) {
	recentConnections.remove(execEnv);
	recentConnections.add(0, execEnv);
	storeRecentConnectionsList();
	}
	}
	/*package-local for test purposes*/ void storeRecentConnectionsList() {
	Preferences prefs = NbPreferences.forModule(ConnectionManager.class);
	synchronized (recentConnections) {
	for (int i = 0; i < recentConnections.size(); i++) {
	prefs.put(getConnectoinsHistoryKey(i), ExecutionEnvironmentFactory.toUniqueID(recentConnections.get(i)));
	}
	}
	}
	/*package-local for test purposes*/ void restoreRecentConnectionsList() {
	Preferences prefs = NbPreferences.forModule(ConnectionManager.class);
	synchronized (recentConnections) {
	recentConnections.clear();
	int idx = 0;
	while (true) {
	String id = prefs.get(getConnectoinsHistoryKey(idx), null);
	if (id == null) {
	break;
	}
	recentConnections.add(ExecutionEnvironmentFactory.fromUniqueID(id));
	idx++;
	}
	}
	}

Indeed there is no size limit.

As a work around the file $NETBEANS_CONFIGDIR/config/Preferences/org/netbeans/dlight/nativeexecution.properties can be manually edited. The entries with the prefix org.netbeans.modules.nativeexecution.api.util.ConnectionManager_connection.history are the history entries. The entries with the prefix org.netbeans.modules.nativeexecution.api.util.Authentication_ prefix hold the authentication information for the entry.

[jherkel]

@matthiasblaesing I want to fix this issue. I think that a simple delete button can be sufficient. What do you think?

[matthiasblaesing]

@jherkel thanks for taking care. I think the button would make sense. The alternative I would see is a complete different panel, but that seems a bit overkill just to delete an entry.

[wumpz]

My understanding is, that the issue is about this dialog and the list of username/host pairs in the dropdown list:

that dialog can be invoked from the terminal window tab:

That list is not associated with the ssh known_hosts file.

Thats what I ment. The ssh known hosts I can handle. Sorry for not being clear enough.

[jherkel]

@matthiasblaesing I fixed this issue but I needed to add a new method to ConnectionManager (ide/dlight.nativeexecution/src/org/netbeans/modules/nativeexecution/api/util/ConnectionManager.java). Now I'm not sure if there is something more I need to do because of this. (increment version or something like this).

[matthiasblaesing]

The general idea is, that if a module exposes an API the change is to be documented in apichanges.xml. However the dlight.nativeexecution has no public API (the API is friend only), so rules are relaxed. Additions to the API of a module in general require a spec version bump (minor version), but minors are bumped on each release, so changing the version is not strictly necessary. Users of "dev" versions will need to use a consistent set of modules built from the same source though.

The dependent module needs to raise the dependency it declares to the current spec version of the dependency, so that it is ensured, that the added functionality is present.

Inspiration for the functionality might be taken from the SQL history, which covers a similar usecase: