Skip to content

Commit bb23d9f

Browse files
committed
Additional changes to the DigitalOcean tests to avoid cross test
pollution and related failures when running tests in parallel.
1 parent 841dea7 commit bb23d9f

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

libcloud/test/common/test_digitalocean_v2.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,14 @@
2222
from libcloud.test.secrets import DIGITALOCEAN_v2_PARAMS
2323
from libcloud.test.file_fixtures import FileFixtures
2424
from libcloud.common.digitalocean import DigitalOceanBaseDriver
25+
from libcloud.common.digitalocean import DigitalOcean_v2_BaseDriver
2526
from libcloud.dns.drivers.digitalocean import DigitalOceanDNSDriver
2627

2728

2829
class DigitalOceanTests(LibcloudTestCase):
2930
def setUp(self):
3031
DigitalOceanBaseDriver.connectionCls.conn_class = DigitalOceanCommonMockHttp
32+
DigitalOcean_v2_BaseDriver.connectionCls.conn_class = DigitalOceanCommonMockHttp
3133
DigitalOceanCommonMockHttp.type = None
3234
self.driver = DigitalOceanBaseDriver(*DIGITALOCEAN_v2_PARAMS)
3335

libcloud/test/compute/test_digitalocean_v2.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from libcloud.test.secrets import DIGITALOCEAN_v1_PARAMS, DIGITALOCEAN_v2_PARAMS
2525
from libcloud.utils.iso8601 import UTC
2626
from libcloud.test.file_fixtures import ComputeFileFixtures
27-
from libcloud.common.digitalocean import DigitalOcean_v1_Error
27+
from libcloud.common.digitalocean import DigitalOcean_v1_Error, DigitalOceanBaseDriver
2828
from libcloud.compute.drivers.digitalocean import DigitalOceanNodeDriver
2929

3030
try:
@@ -36,13 +36,16 @@
3636
# class DigitalOceanTests(unittest.TestCase, TestCaseMixin):
3737
class DigitalOcean_v2_Tests(LibcloudTestCase):
3838
def setUp(self):
39+
DigitalOceanBaseDriver.connectionCls.conn_class = DigitalOceanComputeMockHttp
3940
DigitalOceanNodeDriver.connectionCls.conn_class = DigitalOceanComputeMockHttp
4041
DigitalOceanComputeMockHttp.type = None
4142
self.driver = DigitalOceanNodeDriver(*DIGITALOCEAN_v2_PARAMS)
4243

4344
def tearDown(self):
4445
LibcloudConnection.type = None
4546
DigitalOceanComputeMockHttp.type = None
47+
DigitalOceanBaseDriver.connectionCls.conn_class = LibcloudConnection
48+
DigitalOceanNodeDriver.connectionCls.conn_class = LibcloudConnection
4649

4750
def test_v1_Error(self):
4851
self.assertRaises(

libcloud/test/dns/test_digitalocean.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,22 @@
2121
from libcloud.utils.py3 import httplib
2222
from libcloud.test.secrets import DIGITALOCEAN_v2_PARAMS
2323
from libcloud.test.file_fixtures import DNSFileFixtures
24+
from libcloud.common.digitalocean import DigitalOceanBaseDriver
2425
from libcloud.dns.drivers.digitalocean import DigitalOceanDNSDriver
2526

2627

2728
class DigitalOceanDNSTests(LibcloudTestCase):
2829
def setUp(self):
30+
DigitalOceanBaseDriver.connectionCls.conn_class = DigitalOceanDNSMockHttp
2931
DigitalOceanDNSDriver.connectionCls.conn_class = DigitalOceanDNSMockHttp
3032
DigitalOceanDNSMockHttp.type = None
3133
self.driver = DigitalOceanDNSDriver(*DIGITALOCEAN_v2_PARAMS)
3234

3335
def tearDown(self):
3436
LibcloudConnection.type = None
3537
DigitalOceanDNSMockHttp.type = None
38+
DigitalOceanBaseDriver.connectionCls.conn_class = LibcloudConnection
39+
DigitalOceanDNSDriver.connectionCls.conn_class = LibcloudConnection
3640

3741
def test_list_zones(self):
3842
zones = self.driver.list_zones()

0 commit comments

Comments
 (0)