fix: include missing crates in publish workflow#2485
Open
geserdugarov wants to merge 1 commit into
Open
Conversation
Contributor
Author
blackmwk
requested changes
May 23, 2026
Contributor
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @geserdugarov for this pr. Though I think this is a good fix, maintaining such pacakges manually in publish.yml is the right direction to go. The reason is that it's quite easy to have wrong publishing order. We should use cargo publish --workspace to do it, and mark non publishing crates as false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Which issue does this PR close?
What changes are included in this PR?
iceberg-cache-mokaandiceberg-catalog-loaderto the publish workflow so all README-listed crates are released.icebergfirst, then storage, then crates that only depend oniceberg, then storage-backed catalog crates, andiceberg-catalog-loaderlast because it depends on catalog crates.iceberg-cache-moka.Are these changes tested?
The actual publish workflow is only exercised on release tags, so the relevant local validation is a Cargo publish dry run.