Skip to content

Commit fb00837

Browse files
committed
dont iterate over all tables in sql catalog drop_namespace test
1 parent 34c6e33 commit fb00837

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pyiceberg/catalog/sql.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,8 +569,12 @@ def drop_namespace(self, namespace: str | Identifier) -> None:
569569
raise NoSuchNamespaceError(f"Namespace does not exist: {namespace}")
570570

571571
namespace_str = Catalog.namespace_to_string(namespace)
572-
if tables := list(self.list_tables(namespace)):
572+
tables = self.list_tables(namespace)
573+
try:
574+
next(tables)
573575
raise NamespaceNotEmptyError(f"Namespace {namespace_str} is not empty. {len(list(tables))} tables exist.")
576+
except StopIteration:
577+
pass
574578

575579
with Session(self.engine) as session:
576580
session.execute(

0 commit comments

Comments
 (0)