fix PR issues

Author: rambleraptor

pyiceberg/table/metadata.py

@@ -560,9 +560,6 @@ def construct_refs(cls, table_metadata: TableMetadata) -> TableMetadata:
     next_row_id: Optional[int] = Field(alias="next-row-id", default=None)
     """A long higher than all assigned row IDs; the next snapshot's `first-row-id`."""
 
-    row_lineage: Optional[bool] = Field(alias="row-lineage", default=False)
-    """Setting whether or not to track the creation and updates to rows in the table."""
-
     def model_dump_json(
         self, exclude_none: bool = True, exclude: Optional[Any] = None, by_alias: bool = True, **kwargs: Any
     ) -> str:

pyiceberg/table/snapshots.py

@@ -247,9 +247,7 @@ class Snapshot(IcebergBaseModel):
     first_row_id: Optional[int] = Field(
         alias="first-row-id", default=None, description="assigned to the first row in the first data file in the first manifest"
     )
-    added_rows: Optional[int] = Field(
-        alias="added-rows", default=None, description="Sum of the `added_rows_count` from all manifests added in this snapshot."
-    )
+    _added_rows: Optional[int] = PrivateAttr()
 
     def __str__(self) -> str:
         """Return the string representation of the Snapshot class."""
@@ -263,6 +261,10 @@ def manifests(self, io: FileIO) -> List[ManifestFile]:
         """Return the manifests for the given snapshot."""
         return list(_manifests(io, self.manifest_list))
 
+    @property
+    def added_rows(self) -> Optional[int]:
+        return self._added_rows
+
 
 class MetadataLogEntry(IcebergBaseModel):
     metadata_file: str = Field(alias="metadata-file")

pyiceberg/table/update/snapshot.py

@@ -296,12 +296,10 @@ def _commit(self) -> UpdatesAndRequirements:
         ) as writer:
             writer.add_manifests(new_manifests)
 
-        added_rows: Optional[int] = None
         first_row_id: Optional[int] = None
 
         if self._transaction.table_metadata.format_version >= 3:
             first_row_id = self._transaction.table_metadata.next_row_id
-            added_rows = self._calculate_added_rows(new_manifests)
 
         snapshot = Snapshot(
             snapshot_id=self._snapshot_id,
@@ -310,7 +308,6 @@ def _commit(self) -> UpdatesAndRequirements:
             sequence_number=next_sequence_number,
             summary=summary,
             schema_id=self._transaction.table_metadata.current_schema_id,
-            added_rows=added_rows,
             first_row_id=first_row_id,
         )
 

tests/table/test_snapshots.py

@@ -139,15 +139,15 @@ def test_deserialize_snapshot_with_properties(snapshot_with_properties: Snapshot
 def test_snapshot_repr(snapshot: Snapshot) -> None:
     assert (
         repr(snapshot)
-        == """Snapshot(snapshot_id=25, parent_snapshot_id=19, sequence_number=200, timestamp_ms=1602638573590, manifest_list='s3:/a/b/c.avro', summary=Summary(Operation.APPEND), schema_id=3)"""
+        == """Snapshot(snapshot_id=25, parent_snapshot_id=19, sequence_number=200, timestamp_ms=1602638573590, manifest_list='s3:/a/b/c.avro', summary=Summary(Operation.APPEND), schema_id=3, first_row_id=None)"""
     )
     assert snapshot == eval(repr(snapshot))
 
 
 def test_snapshot_with_properties_repr(snapshot_with_properties: Snapshot) -> None:
     assert (
         repr(snapshot_with_properties)
-        == """Snapshot(snapshot_id=25, parent_snapshot_id=19, sequence_number=200, timestamp_ms=1602638573590, manifest_list='s3:/a/b/c.avro', summary=Summary(Operation.APPEND, **{'foo': 'bar'}), schema_id=3)"""
+        == """Snapshot(snapshot_id=25, parent_snapshot_id=19, sequence_number=200, timestamp_ms=1602638573590, manifest_list='s3:/a/b/c.avro', summary=Summary(Operation.APPEND, **{'foo': 'bar'}), schema_id=3, first_row_id=None)"""
     )
     assert snapshot_with_properties == eval(repr(snapshot_with_properties))