rebase

Author: rambleraptor

pyiceberg/catalog/__init__.py

@@ -37,10 +37,8 @@
     NamespaceAlreadyExistsError,
     NoSuchNamespaceError,
     NoSuchTableError,
-    NoSuchViewError,
     NotInstalledError,
     TableAlreadyExistsError,
-    ViewAlreadyExistsError,
 )
 from pyiceberg.io import FileIO, load_file_io
 from pyiceberg.manifest import ManifestFile

pyiceberg/catalog/bigquery_metastore.py

@@ -334,6 +334,9 @@ def load_view(self, identifier: str | Identifier) -> View:
         raise NotImplementedError
 
     @override
+    def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
+        raise NotImplementedError
+
     def load_namespace_properties(self, namespace: str | Identifier) -> Properties:
         dataset_name = self.identifier_to_database(namespace)
 

pyiceberg/catalog/rest/__init__.py

@@ -1475,7 +1475,7 @@ def drop_view(self, identifier: str | Identifier) -> None:
             _handle_non_200_response(exc, {404: NoSuchViewError})
 
     @retry(**_RETRY_ARGS)
-    def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
+    def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
         payload = {
             "source": self._split_identifier_for_json(from_identifier),
             "destination": self._split_identifier_for_json(to_identifier),

pyiceberg/catalog/sql.py

@@ -785,5 +785,5 @@ def close(self) -> None:
         if hasattr(self, "engine"):
             self.engine.dispose()
 
-    def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
+    def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
         raise NotImplementedError

tests/catalog/test_rest.py

@@ -3189,8 +3189,8 @@ def test_rename_view_204(rest_mock: Mocker) -> None:
     catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
     catalog.rename_view(from_identifier, to_identifier)
     assert (
-        rest_mock.last_request.text
-        == '''{"source": {"namespace": ["some_namespace"], "name": "old_view"}, "destination": {"namespace": ["some_namespace"], "name": "new_view"}}'''
+        rest_mock.last_request.text == """{"source": {"namespace": ["some_namespace"], "name": "old_view"}, """
+        """"destination": {"namespace": ["some_namespace"], "name": "new_view"}}"""
     )