Skip to content

Commit 9674947

Browse files
committed
address feedback and fix filter
1 parent e5242cf commit 9674947

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pyiceberg/catalog/rest/scan_planning.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from pydantic import Field, model_validator
2525

2626
from pyiceberg.catalog.rest.response import ErrorResponseMessage
27-
from pyiceberg.expressions import BooleanExpression
27+
from pyiceberg.expressions import BooleanExpression, SerializableBooleanExpression
2828
from pyiceberg.manifest import FileFormat
2929
from pyiceberg.typedef import IcebergBaseModel
3030

@@ -186,12 +186,13 @@ class PlanTableScanRequest(IcebergBaseModel):
186186

187187
snapshot_id: int | None = Field(alias="snapshot-id", default=None)
188188
select: list[str] | None = Field(default=None)
189-
filter: BooleanExpression | None = Field(default=None)
189+
filter: SerializableBooleanExpression | None = Field(default=None)
190190
case_sensitive: bool = Field(alias="case-sensitive", default=True)
191191
use_snapshot_schema: bool = Field(alias="use-snapshot-schema", default=False)
192192
start_snapshot_id: int | None = Field(alias="start-snapshot-id", default=None)
193193
end_snapshot_id: int | None = Field(alias="end-snapshot-id", default=None)
194194
stats_fields: list[str] | None = Field(alias="stats-fields", default=None)
195+
min_rows_requested: int | None = Field(alias="min-rows-requested", default=None)
195196

196197
@model_validator(mode="after")
197198
def _validate_snapshot_fields(self) -> PlanTableScanRequest:

0 commit comments

Comments
 (0)