Added test for namespace exists

Author: rambleraptor

tests/catalog/test_rest.py

@@ -1924,6 +1924,11 @@ def test_rest_catalog_context_manager_with_exception_sigv4(self, rest_mock: Mock
 def test_rename_view_204(rest_mock: Mocker) -> None:
     from_identifier = ("some_namespace", "old_view")
     to_identifier = ("some_namespace", "new_view")
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/some_namespace",
+        status_code=200,
+        request_headers=TEST_HEADERS,
+    )
     rest_mock.post(
         f"{TEST_URI}v1/views/rename",
         json={
@@ -1937,13 +1942,18 @@ def test_rename_view_204(rest_mock: Mocker) -> None:
     catalog.rename_view(from_identifier, to_identifier)
     assert (
         rest_mock.last_request.text
-        == """{"source": {"namespace": ["some_namespace"], "name": "old_view"}, "destination": {"namespace": ["some_namespace"], "name": "new_view"}}"""
+        == '''{"source": {"namespace": ["some_namespace"], "name": "old_view"}, "destination": {"namespace": ["some_namespace"], "name": "new_view"}}'''
     )
 
 
 def test_rename_view_404(rest_mock: Mocker) -> None:
     from_identifier = ("some_namespace", "non_existent_view")
     to_identifier = ("some_namespace", "new_view")
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/some_namespace",
+        status_code=200,
+        request_headers=TEST_HEADERS,
+    )
     rest_mock.post(
         f"{TEST_URI}v1/views/rename",
         json={
@@ -1965,6 +1975,11 @@ def test_rename_view_404(rest_mock: Mocker) -> None:
 def test_rename_view_409(rest_mock: Mocker) -> None:
     from_identifier = ("some_namespace", "old_view")
     to_identifier = ("some_namespace", "existing_view")
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/some_namespace",
+        status_code=200,
+        request_headers=TEST_HEADERS,
+    )
     rest_mock.post(
         f"{TEST_URI}v1/views/rename",
         json={
@@ -1981,3 +1996,45 @@ def test_rename_view_409(rest_mock: Mocker) -> None:
     with pytest.raises(ViewAlreadyExistsError) as exc_info:
         catalog.rename_view(from_identifier, to_identifier)
     assert "View already exists: some_namespace.existing_view" in str(exc_info.value)
+
+
+def test_rename_view_source_namespace_does_not_exist(rest_mock: Mocker) -> None:
+    from_identifier = ("non_existent_namespace", "old_view")
+    to_identifier = ("some_namespace", "new_view")
+
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/non_existent_namespace",
+        status_code=404,
+        request_headers=TEST_HEADERS,
+    )
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/some_namespace",
+        status_code=200,
+        request_headers=TEST_HEADERS,
+    )
+
+    catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
+    with pytest.raises(NoSuchNamespaceError) as exc_info:
+        catalog.rename_view(from_identifier, to_identifier)
+    assert "Source namespace does not exist: ('non_existent_namespace',)" in str(exc_info.value)
+
+
+def test_rename_view_destination_namespace_does_not_exist(rest_mock: Mocker) -> None:
+    from_identifier = ("some_namespace", "old_view")
+    to_identifier = ("non_existent_namespace", "new_view")
+
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/some_namespace",
+        status_code=200,
+        request_headers=TEST_HEADERS,
+    )
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/non_existent_namespace",
+        status_code=404,
+        request_headers=TEST_HEADERS,
+    )
+
+    catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
+    with pytest.raises(NoSuchNamespaceError) as exc_info:
+        catalog.rename_view(from_identifier, to_identifier)
+    assert "Destination namespace does not exist: non_existent_namespace" in str(exc_info.value)