PR comments

Author: rambleraptor

pyiceberg/table/snapshots.py

@@ -257,6 +257,22 @@ def __str__(self) -> str:
         result_str = f"{operation}id={self.snapshot_id}{parent_id}{schema_id}"
         return result_str
 
+    def __repr__(self) -> str:
+        """Return the string representation of the Snapshot class."""
+        fields = [
+            f"snapshot_id={self.snapshot_id}",
+            f"parent_snapshot_id={self.parent_snapshot_id}",
+            f"sequence_number={self.sequence_number}",
+            f"timestamp_ms={self.timestamp_ms}",
+            f"manifest_list='{self.manifest_list}'",
+            f"summary={repr(self.summary)}" if self.summary else None,
+            f"schema_id={self.schema_id}" if self.schema_id is not None else None,
+            f"first_row_id={self.first_row_id}" if self.first_row_id is not None else None,
+            f"added_rows={self.added_rows}" if self.added_rows is not None else None,
+        ]
+        filtered_fields = [field for field in fields if field is not None]
+        return f"Snapshot({', '.join(filtered_fields)})"
+
     def manifests(self, io: FileIO) -> List[ManifestFile]:
         """Return the manifests for the given snapshot."""
         return list(_manifests(io, self.manifest_list))

tests/integration/test_writes/test_writes.py

@@ -2493,13 +2493,12 @@ def test_stage_only_overwrite_files(
 
 
 @pytest.mark.integration
-def test_v3_write_and_read(spark: SparkSession, session_catalog: Catalog) -> None:
+def test_v3_write_and_read_row_lineage(spark: SparkSession, session_catalog: Catalog) -> None:
     """Test writing to a v3 table and reading with Spark."""
     identifier = "default.test_v3_write_and_read"
     tbl = _create_table(session_catalog, identifier, {"format-version": "3"})
     assert tbl.format_version == 3, f"Expected v3, got: v{tbl.format_version}"
-    assert tbl.metadata.next_row_id is not None, "Expected next_row_id to be initialized"
-    initial_next_row_id = tbl.metadata.next_row_id
+    initial_next_row_id = tbl.metadata.next_row_id or 0
 
     test_data = pa.Table.from_pydict(
         {
@@ -2527,7 +2526,4 @@ def test_v3_write_and_read(spark: SparkSession, session_catalog: Catalog) -> Non
 
     assert (
         tbl.metadata.next_row_id == initial_next_row_id + len(test_data)
-    ), "Expected next_row_id to be incremented by the number of added rows"
-
-    df = spark.table(identifier)
-    assert df.count() == 3, "Expected 3 rows"
+    ), "Expected next_row_id to be incremented by the number of added rows"